refactor: split branches from channels in data model#1177
Open
fricklerhandwerk wants to merge 3 commits into
Open
refactor: split branches from channels in data model#1177fricklerhandwerk wants to merge 3 commits into
fricklerhandwerk wants to merge 3 commits into
Conversation
The main change is to parse the metadata more rigorously. Secondary is a more explicit encapsulation and documentation of the heuristic for deriving release branch names. Otherwise it's a simplification. It's not necessary to fetch the channel's commits at this point, since we're already doing that before evaluation.
Also fetch the tip of each underlying release branch when refreshing channels. This in principle allows evaluating just the release branches and, independently, using package data from already evalauted channels. That way we will be able to track both what maintainers are working on and what is shipped to users, without evaluating all involved versions ourselves. Also remove the repository from the channel model. It's not used for anything and can be recovered from the configuration constants if ever needed.
The atomic update makes it slightly more robust against interruptions. This is done in a separate commit to keep the previous addition of fetching branch tips readable.
fricklerhandwerk
force-pushed
the
branch-model
branch
from
adb46f6 to
7413c7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #864
Depends on #1176
Also fetch the tip of each underlying release branch when refreshing
channels.
This in principle allows evaluating just the release branches and,
independently, using package data from already evalauted channels. That way
we will be able to track both what maintainers are working on and what is
shipped to users, without evaluating all involved versions ourselves.