fix: production type error on Git clone URL#1180
Merged
Merged
Conversation
That type mismatch is currently not caught in tests. Tests set that URL, which takes the `USER_SETTINGS_FILE` code path. That's a deprecated way for configuring the service, which bypasses the Pydantic parser and takes the value as `str`. Production uses the implicit default, which is taken as `HttpUrl` from Pydantic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That type mismatch is currently not caught in tests.
Tests set that URL, which takes the
USER_SETTINGS_FILEcode path.That's a deprecated way for configuring the service, which bypasses the Pydantic parser and takes the value as
str.Production uses the implicit default, which is taken as
HttpUrlfrom Pydantic.The underlying problem is fixed in #1166, but that takes a bit more care.