refactor: added overlay base model for all overlay model to inherit.#943
Draft
adekoder wants to merge 1 commit into
Draft
refactor: added overlay base model for all overlay model to inherit.#943adekoder wants to merge 1 commit into
adekoder wants to merge 1 commit into
Conversation
Collaborator
|
To avoid dumping dead code (however short-lived), I recommend doing the event name migration first (separately), and then moving the special cases under the base class together with the addition of the base class. |
Collaborator
Author
sure ... noted |
Collaborator
|
Depends on #944 |
Collaborator
There was a problem hiding this comment.
Maybe just put it into models/linkage.py so it stays together.
| from django.db import models | ||
| from django.utils.translation import gettext_lazy as _ | ||
|
|
||
| class BaseAbstractOverlay(models.Model): |
Collaborator
There was a problem hiding this comment.
Suggested change
| class BaseAbstractOverlay(models.Model): | |
| class Overlay(models.Model): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
We are refactoring the naming of the respective models
MaintainersEditandPackageEditand subsequent similar models to hand similar type of edit, they are basically an Overlay an not anEditsince we are not actually editing the maintainers or the packages.This PR is to create a structure this type of models by introducing a Base Abstract Class that check similar model can inherit from, this keep the part of the system organise since there is already a pattern established here.