Revert "move check to DerivationOptions::fromEnv"

This reverts commit 11e04e0.

Author: haenoe

src/libstore/derivations.cc

@@ -518,27 +518,6 @@ DerivationOptions DerivationOptions::fromEnv(const StringPairs & env)
 
     DerivationOptions defaults = {};
 
-    if (auto structuredAttrs = parsed.getStructuredAttrs()) {
-        if (get(*structuredAttrs, "allowedReferences")){
-            warn("'structuredAttrs' disables the effect of the top-level attribute 'allowedReferences'; use 'outputChecks' instead");
-        }
-        if (get(*structuredAttrs, "allowedRequisites")){
-            warn("'structuredAttrs' disables the effect of the top-level attribute 'allowedRequisites'; use 'outputChecks' instead");
-        }
-        if (get(*structuredAttrs, "disallowedRequisites")){
-            warn("'structuredAttrs' disables the effect of the top-level attribute 'disallowedRequisites'; use 'outputChecks' instead");
-        }
-        if (get(*structuredAttrs, "disallowedReferences")){
-            warn("'structuredAttrs' disables the effect of the top-level attribute 'disallowedReferences'; use 'outputChecks' instead");
-        }
-        if (get(*structuredAttrs, "maxSize")){
-            warn("'structuredAttrs' disables the effect of the top-level attribute 'maxSize'; use 'outputChecks' instead");
-        }
-        if (get(*structuredAttrs, "maxClosureSize")){
-            warn("'structuredAttrs' disables the effect of the top-level attribute 'maxClosureSize'; use 'outputChecks' instead");
-        }
-    }
-
     return {
         .checksPerOutput = parseChecksPerOutput(parsed),
         .checksAllOutputs = parsed.getStructuredAttrs()

src/libstore/unix/build/local-derivation-goal.cc

@@ -2889,6 +2889,27 @@ void LocalDerivationGoal::checkOutputs(const std::map<std::string, ValidPathInfo
             checkRefs(checks.disallowedRequisites, false, true);
         };
 
+        if (auto structuredAttrs = parsedDrv->getStructuredAttrs()) {
+            if (get(*structuredAttrs, "allowedReferences")){
+                warn("'structuredAttrs' disables the effect of the top-level attribute 'allowedReferences'; use 'outputChecks' instead");
+            }
+            if (get(*structuredAttrs, "allowedRequisites")){
+                warn("'structuredAttrs' disables the effect of the top-level attribute 'allowedRequisites'; use 'outputChecks' instead");
+            }
+            if (get(*structuredAttrs, "disallowedRequisites")){
+                warn("'structuredAttrs' disables the effect of the top-level attribute 'disallowedRequisites'; use 'outputChecks' instead");
+            }
+            if (get(*structuredAttrs, "disallowedReferences")){
+                warn("'structuredAttrs' disables the effect of the top-level attribute 'disallowedReferences'; use 'outputChecks' instead");
+            }
+            if (get(*structuredAttrs, "maxSize")){
+                warn("'structuredAttrs' disables the effect of the top-level attribute 'maxSize'; use 'outputChecks' instead");
+            }
+            if (get(*structuredAttrs, "maxClosureSize")){
+                warn("'structuredAttrs' disables the effect of the top-level attribute 'maxClosureSize'; use 'outputChecks' instead");
+            }
+        }
+
         if (auto outputChecks = get(drv->options.checksPerOutput, outputName))
             applyChecks(*outputChecks);