Clarify that --keep-failed with remote builders will keep the failed build directory on that builder#13320
Merged
Mic92 merged 2 commits intoJun 3, 2025
Conversation
…tory on that builder
… is supported on this machine
github-actions
Bot
added
the
with-tests
roberth
added
backport 2.28-maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While some may be able to intuit that passing
--keep-failedwhen using remote builders will indeed keep the failed build directory on the remote builder, others may expect it to be accessible on the local machine (especially when the build log includes the messagenote: keeping build directory '/tmp/nix-shell.8G497s/nix-build-failing.drv-16/build'for example).This adds a warning in the case that a remote build fails and
--keep-failedwas passed, to inform the user that the failed build directory was kept -- but on the remote builder itself.Context
Related: DeterminateSystems#85
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.