libstore/build/local-derivation-goal: error earlier when sandbox path is inaccessible#13396
Open
cole-h wants to merge 1 commit into
Open
libstore/build/local-derivation-goal: error earlier when sandbox path is inaccessible#13396cole-h wants to merge 1 commit into
cole-h wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
with-tests
xokdvium
reviewed
Jul 1, 2025
Comment on lines
+906
to
+920
|
|
||
| std::string inside, outside; | ||
| if (p == std::string::npos) { | ||
| inside = i; | ||
| outside = i; | ||
| } else { | ||
| inside = i.substr(0, p); | ||
| outside = i.substr(p + 1); | ||
| } | ||
|
|
||
| if (!optional && !maybeLstat(outside)) { | ||
| throw SysError("path '%s' is configured as part of the `sandbox-paths` option, but is inaccessible", outside); | ||
| } | ||
|
|
||
| pathsInChroot[inside] = {outside, optional}; |
Contributor
There was a problem hiding this comment.
FWIW I think all of the parsing and preprocessing code should be done in a less ad-hoc way. Can't the sandboxPaths setting be a better datastructure like a map of path -> path + attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port of DeterminateSystems#88.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.