Skip to content

Clarify that --keep-failed with remote builders will keep the failed build directory on that builder (backport #13320)#13616

Closed
mergify[bot] wants to merge 2 commits into
2.29-maintenancefrom
mergify/bp/2.29-maintenance/pr-13320
Closed

Clarify that --keep-failed with remote builders will keep the failed build directory on that builder (backport #13320)#13616
mergify[bot] wants to merge 2 commits into
2.29-maintenancefrom
mergify/bp/2.29-maintenance/pr-13320

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Jul 30, 2025

Motivation

While some may be able to intuit that passing --keep-failed when using remote builders will indeed keep the failed build directory on the remote builder, others may expect it to be accessible on the local machine (especially when the build log includes the message note: keeping build directory '/tmp/nix-shell.8G497s/nix-build-failing.drv-16/build' for example).

This adds a warning in the case that a remote build fails and --keep-failed was passed, to inform the user that the failed build directory was kept -- but on the remote builder itself.

Context

Related: DeterminateSystems#85


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.


This is an automatic backport of pull request #13320 done by [Mergify](https://mergify.com).

cole-h added 2 commits July 30, 2025 12:38
…tory on that builder

(cherry picked from commit 0712339)

# Conflicts:
#	src/build-remote/build-remote.cc
… is supported on this machine

(cherry picked from commit 54aa73b)
@mergify mergify Bot added automatic backport This PR is a backport produced by automation (does not trigger backporting) conflicts merge-queue labels Jul 30, 2025
@mergify mergify Bot requested a review from edolstra as a code owner July 30, 2025 12:38
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Jul 30, 2025

Cherry-pick of 0712339 has failed:

On branch mergify/bp/2.29-maintenance/pr-13320
Your branch is up to date with 'origin/2.29-maintenance'.

You are currently cherry-picking commit 071233991.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   tests/functional/build-remote.sh

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/build-remote/build-remote.cc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify Bot added merge-queue conflicts automatic backport This PR is a backport produced by automation (does not trigger backporting) labels Jul 30, 2025
@github-actions github-actions Bot added the with-tests Issues related to testing. PRs with tests have some priority label Jul 30, 2025
@edolstra edolstra closed this Aug 25, 2025
@xokdvium xokdvium deleted the mergify/bp/2.29-maintenance/pr-13320 branch October 7, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automatic backport This PR is a backport produced by automation (does not trigger backporting) conflicts merge-queue with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants