eval-cache: Add derivation result as temproot#15616
Merged
Merged
Conversation
Closes the window where the derivation could be garbage collected after we checked isValidPath.
dramforever
commented
Apr 2, 2026
dramforever
force-pushed
the
more-temproots
branch
from
f3dddd6 to
47a3ef0
Compare
github-actions
Bot
added
the
store
Contributor
Author
|
Marked as draft for now. I'll add a batched (Edit: Deferred to a future PR) |
edolstra
reviewed
Apr 2, 2026
dramforever
changed the title
dramforever
force-pushed
the
more-temproots
branch
from
47a3ef0 to
90db12c
Compare
xokdvium
reviewed
Apr 10, 2026
xokdvium
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Three more missed temproots, hopefully fixed. You know the drill.Closes the window where the derivation could be garbage collected after we checked isValidPath.
(This PR had three fixes at one time, but two other cases have been split off for later, since it is unclear that the approach was correct.)
Context
See also #15237 and #15469 for more temproots whack-a-mole.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.