Fix git lfs for github fetcher#15891
Draft
lisanna-dettwyler wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
the
fetching
lisanna-dettwyler
force-pushed
the
fix-lfs-url
branch
4 times, most recently
from
d40fdcc to
61375c3
Compare
According to https://github.com/git-lfs/git-lfs/blob/main/docs/api/server-discovery.md LFS endpoints must end in `.git`. Resolves NixOS#15285 Signed-off-by: Lisanna Dettwyler <lisanna.dettwyler@gmail.com>
lisanna-dettwyler
force-pushed
the
fix-lfs-url
branch
from
61375c3 to
2d067cc
Compare
xokdvium
reviewed
May 20, 2026
Comment on lines
+8
to
+22
| struct GitLFSTest : public ::testing::Test | ||
| { | ||
| void test(std::string input, std::string expected) | ||
| { | ||
| ASSERT_EQ(getLfsApi(parseURL(input)).endpoint, expected); | ||
| } | ||
| }; | ||
|
|
||
| TEST_F(GitLFSTest, get_lfs_api) | ||
| { | ||
| test("https://git-server.com/foo/bar", "https://git-server.com/foo/bar.git/info/lfs"); | ||
| test("https://git-server.com/foo/bar.git", "https://git-server.com/foo/bar.git/info/lfs"); | ||
| test("https://git-server.com", "https://git-server.com/.git/info/lfs"); | ||
| test("https://git-server.com/foo/bar/", "https://git-server.com/foo/bar.git//info/lfs"); | ||
| }; |
Contributor
There was a problem hiding this comment.
This can also be a parametrised test if we want to get fancy :)
Contributor
Author
|
I need to look at the corner cases for remotes ending in a slash, marking as draft for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to
https://github.com/git-lfs/git-lfs/blob/main/docs/api/server-discovery.md LFS endpoints must end in
.git.Resolves #15285
Motivation
Attempting to use LFS with a github fetcher can fail with HTTP 422 without this.
Context
Confirmed the fix works in #15285
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.