Skip to content

Commit 2f2221f

Browse files
maintainers: require GitHub handle
At the scale of Nixpkgs, actively maintaining a package is only possible with integration into CI. To be able to be pinged for review requests, the maintainer must have a GitHub handle, which: - Leads to an invitation to the NixOS org, which comes with additional privileges. - Allows to request the maintainer for review as a member of this org. - Automatically requests the maintainer for review in CI. Currently, the GitHub handle is not strictly enforced. This leads to some new maintainers accidentally forgetting to set these. We can avoid these mistakes and enforce them via CI. (cherry picked from commit 568b19f)
1 parent c475510 commit 2f2221f

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

lib/tests/maintainer-module.nix

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,12 @@ in
77
name = lib.mkOption {
88
type = types.str;
99
};
10+
github = lib.mkOption {
11+
type = types.str;
12+
};
13+
githubId = lib.mkOption {
14+
type = types.ints.unsigned;
15+
};
1016
email = lib.mkOption {
1117
type = types.nullOr types.str;
1218
default = null;
@@ -15,14 +21,6 @@ in
1521
type = types.nullOr types.str;
1622
default = null;
1723
};
18-
github = lib.mkOption {
19-
type = types.nullOr types.str;
20-
default = null;
21-
};
22-
githubId = lib.mkOption {
23-
type = types.nullOr types.ints.unsigned;
24-
default = null;
25-
};
2624
keys = lib.mkOption {
2725
type = types.listOf (
2826
types.submodule {

0 commit comments

Comments
 (0)