Skip to content

Commit 43d5f64

Browse files
author
Isidor Zeuner
committed
ci/eval/compare: avoid CI failures on non-github maintainer records
1 parent 0934d96 commit 43d5f64

1 file changed

Lines changed: 12 additions & 6 deletions

File tree

ci/eval/compare/maintainers.nix

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,14 +95,20 @@ let
9595

9696
attrsWithModifiedFiles = builtins.filter (pkg: anyMatchingFiles pkg.filenames) attrsWithFilenames;
9797

98+
# TODO: create ping lists for other contacts once non-GitHub ping
99+
# implementations get merged
98100
listToPing = lib.concatMap (
99101
pkg:
100-
builtins.map (maintainer: {
101-
id = maintainer.githubId;
102-
inherit (maintainer) github;
103-
packageName = pkg.name;
104-
dueToFiles = pkg.filenames;
105-
}) pkg.maintainers
102+
builtins.map
103+
(maintainer: {
104+
id = maintainer.githubId;
105+
inherit (maintainer) github;
106+
packageName = pkg.name;
107+
dueToFiles = pkg.filenames;
108+
})
109+
# TODO: If community consensus (e.g. an RFC) makes `githubId` mandatory,
110+
# simplify to `pkg.maintainers`
111+
(builtins.filter (maintainer: maintainer ? githubId) pkg.maintainers)
106112
) attrsWithModifiedFiles;
107113

108114
byMaintainer = lib.groupBy (ping: toString ping.${if byName then "github" else "id"}) listToPing;

0 commit comments

Comments
 (0)