check-meta: Avoid expensive evaluation of output meta

Thanks for the pointer @llakala!

Author: infinisil

pkgs/stdenv/generic/check-meta.nix

@@ -53,7 +53,7 @@ let
     problemsType
     genCheckProblems
     ;
-  checkProblems = genCheckProblems config;
+  checkProblems = genCheckProblems config defaultRequiresMaintainers;
 
   # If we're in hydra, we can dispense with the more verbose error
   # messages and make problems easier to spot.
@@ -713,10 +713,10 @@ let
     builtins.seq (foldl' giveWarning null warnings) withError;
 
   assertValidity =
-    { meta, attrs }:
+    { meta, attrs, pos ? null }:
     let
       invalid = checkValidity attrs;
-      problems = checkProblems attrs meta;
+      problems = checkProblems attrs pos;
     in
     if isNull invalid then
       if isNull problems then

pkgs/stdenv/generic/make-derivation.nix

@@ -956,7 +956,7 @@ let
           ++ attrs.propagatedNativeBuildInputs or [ ]
           ++ attrs.propagatedBuildInputs or [ ];
       };
-      validity = checkMeta.assertValidity { inherit meta attrs; };
+      validity = checkMeta.assertValidity { inherit meta attrs pos; };
 
       checkedEnv =
         let

pkgs/stdenv/generic/problems.nix

@@ -94,8 +94,8 @@ rec {
     {
       kindName = "maintainerless";
       condition =
-        config: attrs: outputMeta:
-        outputMeta.requiresMaintainers
+        config: attrs: requiresMaintainers:
+        requiresMaintainers
         && (attrs.meta.maintainers or [ ] == [ ])
         && (attrs.meta.teams or [ ] == [ ])
         && (attrs.meta.hasNoMaintainersButDependents or false == false);
@@ -117,16 +117,16 @@ rec {
             else
               x: false;
         in
-        attrs: outputMeta: attrs.meta.broken or false && !allowBroken && !allowBrokenPredicate attrs;
+        attrs: requiresMaintainers: attrs.meta.broken or false && !allowBroken && !allowBrokenPredicate attrs;
       value.message = "This package is broken.";
     }
   ];
 
   genAutomaticProblems =
-    config: attrs: outputMeta:
+    config: attrs: requiresMaintainers:
     listToAttrs (
       map (problem: lib.nameValuePair problem.kindName problem.value) (
-        filter (problem: problem.condition config attrs outputMeta) automaticProblems
+        filter (problem: problem.condition config attrs requiresMaintainers) automaticProblems
       )
     );
 
@@ -425,6 +425,7 @@ rec {
 
   genCheckProblems =
     config:
+    defaultRequiresMaintainers:
     let
       # This is here so that it gets cached for a (checkProblems config) thunk
       inherit (genHandlerSwitch config)
@@ -435,17 +436,18 @@ rec {
         problem: problem // { condition = problem.condition config; }
       ) automaticProblems;
     in
-    attrs: outputMeta:
+    attrs: pos:
     let
       pname = getName attrs;
       manualProblems = attrs.meta.problems or { };
+      requiresMaintainers = attrs.meta.requiresMaintainers or (defaultRequiresMaintainers attrs pos);
     in
     if
       # Fast path for when there's no problem that needs to be handled
       # No automatic problems that needs handling
       all (
         problem:
-        problem.condition attrs outputMeta
+        problem.condition attrs requiresMaintainers
         -> handlerForProblem pname problem.kindName problem.kindName == "ignore"
       ) automaticProblemsConfigCache
       && (
@@ -461,7 +463,7 @@ rec {
     else
       # Slow path, only here we actually figure out which problems we need to handle
       let
-        problems = attrs.meta.problems or { } // genAutomaticProblems config attrs outputMeta;
+        problems = attrs.meta.problems or { } // genAutomaticProblems config attrs requiresMaintainers;
         problemsToHandle = filter (v: v.handler != "ignore") (
           mapAttrsToList (name: problem: rec {
             inherit name;