Skip to content

Commit ba2de00

Browse files
committed
vllm: set rocm env in wrapper
Vllm also wants bash for aiter
1 parent d564fa1 commit ba2de00

1 file changed

Lines changed: 19 additions & 5 deletions

File tree

pkgs/development/python-modules/vllm/default.nix

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,9 @@
9393
cupy,
9494
flashinfer,
9595
nvidia-ml-py,
96+
# rocm-only
97+
pybind11,
98+
bash,
9699

97100
# optional-dependencies
98101
# audio
@@ -584,11 +587,22 @@ buildPythonPackage.override { stdenv = torch.stdenv; } (finalAttrs: {
584587
pythonRelaxDeps = true;
585588

586589
pythonImportsCheck = [ "vllm" ];
587-
makeWrapperArgs = lib.optionals cudaSupport [
588-
"--set"
589-
"VLLM_NCCL_SO_PATH"
590-
"${cudaPackages.nccl}/lib/libnccl.so"
591-
];
590+
makeWrapperArgs =
591+
lib.optionals cudaSupport [
592+
"--set"
593+
"VLLM_NCCL_SO_PATH"
594+
"${cudaPackages.nccl}/lib/libnccl.so"
595+
]
596+
++ lib.optionals rocmSupport [
597+
"--set"
598+
"HIP_DEVICE_LIB_PATH"
599+
"${rocmPackages.rocm-device-libs}/amdgcn/bitcode"
600+
601+
"--prefix"
602+
"PATH"
603+
":"
604+
"${rocmPackages.clr}/bin:${bash}/bin"
605+
];
592606

593607
passthru = {
594608
# make internal dependency available to overlays

0 commit comments

Comments
 (0)