buck2: init at unstable-2023-07-11#243148
Merged
Merged
Conversation
thoughtpolice
force-pushed
the
nixpkgs/buck2-binary
branch
2 times, most recently
from
d5ec838 to
27deff8
Compare
ofborg
Bot
added
8.has: package (new)
Member
Author
|
Note that we could drop the dynamic |
thoughtpolice
force-pushed
the
nixpkgs/buck2-binary
branch
5 times, most recently
from
0370c60 to
7b6aa3c
Compare
Member
Author
|
This has also been updated with an |
thoughtpolice
force-pushed
the
nixpkgs/buck2-binary
branch
from
7b6aa3c to
457d5d0
Compare
Signed-off-by: Austin Seipp <aseipp@pobox.com>
thoughtpolice
force-pushed
the
nixpkgs/buck2-binary
branch
from
457d5d0 to
995167e
Compare
This was referenced Jul 13, 2023
nickgerace
added a commit
to systeminit/si
that referenced
this pull request
Jul 13, 2023
Enabled by the following PR: NixOS/nixpkgs#243148 Signed-off-by: Nick Gerace <nick@systeminit.com>
si-bors-ng Bot
added a commit
to systeminit/si
that referenced
this pull request
Jul 13, 2023
2393: Use upstream buck2 from nixpkgs (ENG-1696) r=nickgerace a=nickgerace Enabled by the following PR: NixOS/nixpkgs#243148 <img src="https://media3.giphy.com/media/xiqeqfNuUMwb1ma26f/giphy.gif"/> Co-authored-by: Nick Gerace <nick@systeminit.com>
![https://media3.giphy.com/media/xiqeqfNuUMwb1ma26f/giphy.gif"/](https://media3.giphy.com/media/xiqeqfNuUMwb1ma26f/giphy.gif"/){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Buck2 team has (rather unexpectedly!) done its first binary prerelease, with an actual version tag; this binary is (still) built with the unstable rust compiler, which blocked #232471 from being merged. But the binary should run fine with a little
patchelfmagic, and, is at least built and deployed directly from GitHub Actions.This adds binaries for all 4 major Unix platforms and just makes the patchelf hook succeeds. It adds myself as the maintainer, as I already am doing a bunch of work on/with buck2. New updates will happen every 2 weeks; the included
update.shscript can helpfully dump out the hashes for you.This should help alleviate #226677; though a source build is of course ideal. That's going to probably be a very far ways off, though. It might explode. Handle with care.
I've only tested this on
x86_64-linux, so we're going to hand off to borg to try it elsewhere.Things done