dorion: 5.0.1 → 6.7.1; dorion: build from source by nyabinary · Pull Request #265771 · NixOS/nixpkgs

nyabinary · 2023-11-06T03:16:46Z

Description of changes

Build from source
Enable WebkitGTK Experimental toggle for WebRTC (To make VCs work)
Added myself to maintainer
Depends on #280554
Depends on #398783 (Currently in staging-next)

Closes #360644

Things done

Huge thanks to @lilyinstarlight this PR wouldn't be possible without her.

pbsds

Impressive! Considering SpikeHD/Dorion#125 is a thing, I consider this PR a ZHF fix. #265948
Runs fine, but a bit more sluggish than the official client. Likely a tauri issue.

pbsds

Sorry for appearing nitpicky, you have done an excellent job. The proposed set of substitutions IMO clearly convey their intent

pbsds

We seem to have a build failure, the proposed fix works on my end

pbsds · 2023-11-19T00:13:06Z

More build failures: unable to parse JSON Tauri config file at /build/source/src-tauri/tauri.conf.json because trailing comma at line 71 column 7

nyabinary · 2023-11-19T01:33:26Z

More build failures: unable to parse JSON Tauri config file at /build/source/src-tauri/tauri.conf.json because trailing comma at line 71 column 7

pain
what could be causing this tho?

getchoo

The libsoup error above remains, and will continue to as long as libsoup_2_4 exists in the dependency chain. We'll need to see if gssdp can build with libsoup3 instead and update it -- or override it here specifically if the change breaks it's dependents

nyabinary · 2025-02-14T12:55:36Z

The libsoup error above remains, and will continue to as long as libsoup_2_4 exists in the dependency chain. We'll need to see if gssdp can build with libsoup3 instead and update it -- or override it here specifically if the change breaks it's dependents

And how can we see that because personally I'm clueless :P

niklaskorz · 2025-02-14T12:59:05Z

The libsoup error above remains, and will continue to as long as libsoup_2_4 exists in the dependency chain. We'll need to see if gssdp can build with libsoup3 instead and update it -- or override it here specifically if the change breaks it's dependents

Homebrew builds it with libsoup 3 so I recon it should be possible

nyabinary · 2025-02-14T13:06:18Z

The libsoup error above remains, and will continue to as long as libsoup_2_4 exists in the dependency chain. We'll need to see if gssdp can build with libsoup3 instead and update it -- or override it here specifically if the change breaks it's dependents

Homebrew builds it with libsoup 3 so I recon it should be possible

Def would appericate it if you could find out :P, I'm pretty clueless on this area tbh

niklaskorz · 2025-02-14T13:48:26Z

Def would appericate it if you could find out :P, I'm pretty clueless on this area tbh

Init version 1.6 of gupnp-igd as gupnp-igd_1_6, depending on gssdp_1_6 and in turn on libsoup3
Update package libnice to use gupnp-igd_1_6 instead of gupnp-igd
Test if a) this builds and b) plays nicely with gstreamer

nyabinary · 2025-02-14T15:51:51Z

Def would appericate it if you could find out :P, I'm pretty clueless on this area tbh

1. Init version 1.6 of gupnp-igd as `gupnp-igd_1_6`, depending on `gssdp_1_6` and in turn on `libsoup3`

2. Update package libnice to use `gupnp-igd_1_6` instead of `gupnp-igd`

3. Test if a) this builds and b) plays nicely with gstreamer

Should libnice be updated globally to use libsoup3 or just be a override?

nyabinary · 2025-03-15T01:44:28Z

Def would appericate it if you could find out :P, I'm pretty clueless on this area tbh

1. Init version 1.6 of gupnp-igd as `gupnp-igd_1_6`, depending on `gssdp_1_6` and in turn on `libsoup3`

2. Update package libnice to use `gupnp-igd_1_6` instead of `gupnp-igd`

3. Test if a) this builds and b) plays nicely with gstreamer

Sorry to ask but can you look into this if possible, been very busy and this is a bit above my skill level rn.

nyabinary · 2025-04-01T12:40:24Z

Potential fix(?) here if anyone wants to help with testing :P
#395063

michaelBelsanti · 2025-04-22T18:05:37Z

Have you been able to build this on the libsoup-updates branch? I've been trying but I don't think I have the memory needed to build webkitgtk-2.48.1+abi=4.1 and gst-plugins-rs-0.13.5 seems to be getting stuck during the check phase.

nyabinary · 2025-05-02T14:29:28Z

Have you been able to build this on the libsoup-updates branch? I've been trying but I don't think I have the memory needed to build webkitgtk-2.48.1+abi=4.1 and gst-plugins-rs-0.13.5 seems to be getting stuck during the check phase.

Seems to work for me :3 just updated the PR

nyabinary · 2025-05-03T20:38:42Z

@ofborg build

michaelBelsanti · 2025-05-04T18:53:13Z

Have you been able to build this on the libsoup-updates branch? I've been trying but I don't think I have the memory needed to build webkitgtk-2.48.1+abi=4.1 and gst-plugins-rs-0.13.5 seems to be getting stuck during the check phase.

Seems to work for me :3 just updated the PR

Yep, builds fine now! Not sure what was getting stuck before.

Ran into a few issues testing it.

Trying to join any VC gets stuck on RTC connecting
The built-in RPC server isn't working correctly with shelterpc, it prints warnings that the insecure connection to "ws://127.0.0.1:1337/" is being blocked.
There's some weird formatting going on with server folders (not sure if this is an upstream issue)

nyabinary · 2025-05-05T15:06:45Z

Have you been able to build this on the libsoup-updates branch? I've been trying but I don't think I have the memory needed to build webkitgtk-2.48.1+abi=4.1 and gst-plugins-rs-0.13.5 seems to be getting stuck during the check phase.

Seems to work for me :3 just updated the PR

Yep, builds fine now! Not sure what was getting stuck before.

Ran into a few issues testing it.

* Trying to join any VC gets stuck on RTC connecting

* The built-in RPC server isn't working correctly with shelterpc, it prints warnings that the insecure connection to "ws://127.0.0.1:1337/" is being blocked.

* There's some weird formatting going on with server folders (not sure if this is an upstream issue)
  ![image](https://private-user-images.githubusercontent.com/62124625/440208875-2dd8e957-a313-4b05-b7dc-fbdbd3097220.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDY0NTc4MjcsIm5iZiI6MTc0NjQ1NzUyNywicGF0aCI6Ii82MjEyNDYyNS80NDAyMDg4NzUtMmRkOGU5NTctYTMxMy00YjA1LWI3ZGMtZmJkYmQzMDk3MjIwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTA1VDE1MDUyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg0NGNhNGRmNWNkY2U3NjgxMjU5NzEyMjk4ZWRmMzk1MzNkOWU4MzliZWE3NWVmYWEyNzVkNmI4NGU5ODcyYWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.rjqBOLWzqHOaWNWw3urGTHCZ-5-NpYWHFZN46KpcADA)

The VC is an upstream issue I think, upstream still needs some work in getting VCs working on Linux :3

michaelBelsanti · 2025-05-05T19:41:10Z

The VC is an upstream issue I think, upstream still needs some work in getting VCs working on Linux :3

Whoops, somehow missed your issue upstream lol. The other issues also seem to be upstream, I'll report them. Otherwise, it seems to work as expected!

nyabinary · 2025-05-06T13:46:34Z

The VC is an upstream issue I think, upstream still needs some work in getting VCs working on Linux :3

Whoops, somehow missed your issue upstream lol. The other issues also seem to be upstream, I'll report them. Otherwise, it seems to work as expected!

Might want to provide the logs in the Discord :3 to help with Discord Linux VC support

nixos-discourse · 2025-05-13T17:23:13Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5471

ghost · 2025-05-24T17:51:02Z

6.7.1 is out

Co-authored-by: griffi-gh <prasol258@gmail.com>

nyabinary · 2025-05-26T15:59:55Z

6.7.1 is out

done

Aleksanaa · 2025-05-26T16:02:13Z

Are there remaining known regressions compared to current binary version?
Have anyone been using this source built version for a relatively long time?

nyabinary · 2025-05-26T16:07:03Z

Are there remaining known regressions compared to current binary version?

Have anyone been using this source built version for a relatively long time?

No in fact, this should be an improvement over the binary version in every way :P since Linux support back then was quite bad.
Been using it for a week as my second client with no problems.

zzzealed · 2025-05-30T09:11:34Z

NixOS 25.05, Plasma 6.3.5 & Nvidia GPU + Wayland

Tried using with nix run github:nixos/nixpkgs/pull/265771/head#dorion but got error:

$ nix run github:nixos/nixpkgs/pull/265771/head#dorion
[2025-05-30 10:25:30] Are we portable? false
[2025-05-30 10:25:30] Starting Dorion version v6.7.1
[2025-05-30 10:25:30] Opening Discord default
[2025-05-30 10:25:31] Joining (load_mods_js)...
[2025-05-30 10:25:31] Plugins updated
[2025-05-30 10:25:31] Multi-instance disabled, registering single instance plugin...
[2025-05-30 10:25:31] Extensions are unsupported on non-Windows platforms!
[2025-05-30 10:25:31] Loading plugins...
[2025-05-30 10:25:31] Preload only: true
[2025-05-30 10:25:31] Starting OS accent subscriber...
[2025-05-30 10:25:31] Starting global keybind watcher...
[2025-05-30 10:25:31] Autolaunch enabled: false
[2025-05-30 10:25:31] Accent color changed Some(Srgba { red: 0.2078431397676468, green: 0.6235294342041016, blue: 0.1411764770746231, alpha: 1.0 })
Gdk-Message: 10:25:32.384: Error 71 (Protocol error) dispatching to Wayland display.

Using GDK_BACKEND=x11 nix run github:nixos/nixpkgs/pull/265771/head#dorion got me:

$ GDK_BACKEND=x11 nix run github:nixos/nixpkgs/pull/265771/head#dori
[2025-05-30 11:01:59] Are we portable? false
[2025-05-30 11:01:59] Starting Dorion version v6.7.1
[2025-05-30 11:01:59] Opening Discord default
[2025-05-30 11:01:59] Joining (load_mods_js)...
[2025-05-30 11:01:59] Plugins updated
[2025-05-30 11:02:00] Multi-instance disabled, registering single instance plugin...
[2025-05-30 11:02:00] Extensions are unsupported on non-Windows platforms!
[2025-05-30 11:02:00] Loading plugins...
[2025-05-30 11:02:00] Preload only: true
[2025-05-30 11:02:00] Starting OS accent subscriber...
[2025-05-30 11:02:00] Starting global keybind watcher...
[2025-05-30 11:02:00] Autolaunch enabled: false
[2025-05-30 11:02:00] Accent color changed Some(Srgba { red: 0.2078431397676468, green: 0.6235294342041016, blue: 0.1411764770746231, alpha: 1.0 })
Failed to create GBM buffer of size 800x600: Invalid argument
[2025-05-30 11:02:00] Loading plugins...
[2025-05-30 11:02:00] Preload only: false
Failed to create GBM buffer of size 800x600: Invalid argument
[2025-05-30 11:02:02] Setting notification count: 0
[2025-05-30 11:02:02] Setting tray icon to default
[2025-05-30 11:02:03] PTT enabled: "{\"state\":false}"
[2025-05-30 11:02:03] Checking for updates...
[2025-05-30 11:02:03] Checking for updates...

Which gave me an empty window. Likely because of Failed to create GBM buffer of size 800x600: Invalid argument, like described here.

PierreBorine · 2025-05-30T16:14:31Z

I got the same result running nix run github:nixos/nixpkgs/pull/265771/head#dorion
Adding GDK_BACKEND=x11 also only got me an empty window.
Adding WEBKIT_DISABLE_DMABUF_RENDERER=1 as suggested here seems to be a working workaround.
I got the app to run and as far as I see, there seems to be no issues. (blur is intentional)

nyabinary · 2025-05-30T21:41:57Z

What should be added to the package to make it work?

getchoo

Tested against NVIDIA driver 570.153.02

Builds and runs basically as expected. As with all Tauri apps, WEBKIT_DISABLE_DMABUF_RENDERER=1 allows it to actually open on my hardware

Only issue I came across is again, WebRTC. No errors this time, I am just forever stuck at "RTC connecting". Based on previous conversations here (and the lack of errors), this is most likely an upstream bug in either Dorion or webkitgtk itself, and not our packaging. I also assume this doesn't work currently anyways(?) in the binary build

I think this is in the best state we'll get right now. Thanks for you work, @nyabinary!

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 265771
Commit: 2f51cb1f8f65c7e0a6f7a8006e88dfd50fc9746f

`x86_64-linux`

✅ 1 package built:

dorion

nyabinary · 2025-05-31T18:39:04Z

Tested against NVIDIA driver 570.153.02

Builds and runs basically as expected. As with all Tauri apps, WEBKIT_DISABLE_DMABUF_RENDERER=1 allows it to actually open on my hardware

Only issue I came across is again, WebRTC. No errors this time, I am just forever stuck at "RTC connecting". Based on previous conversations here (and the lack of errors), this is most likely an upstream bug in either Dorion or webkitgtk itself, and not our packaging. I also assume this doesn't work currently anyways(?) in the binary build

I think this is in the best state we'll get right now. Thanks for you work, @nyabinary!

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 265771 Commit: 2f51cb1f8f65c7e0a6f7a8006e88dfd50fc9746f

x86_64-linux

✅ 1 package built:

Yeah, it doesn't work on binary either :P its an upstream thing.

Aleksanaa · 2025-06-06T11:36:15Z

No further objections from others. Merging. I'm sorry if we find a breakage in the end.

nyabinary force-pushed the dorion branch 3 times, most recently from 25a8866 to 3054e22 Compare November 10, 2023 01:38

pbsds reviewed Nov 10, 2023

View reviewed changes

Comment thread pkgs/by-name/do/dorion/package.nix Outdated

Comment thread pkgs/by-name/do/dorion/package.nix Outdated

Comment thread pkgs/by-name/do/dorion/package.nix Outdated

nyabinary force-pushed the dorion branch from 3054e22 to e3310d7 Compare November 10, 2023 01:39

nyabinary changed the title ~~dorion: 1.2.1 -> 2.1.0~~ dorion: 1.2.1 -> 2.2.0 Nov 10, 2023

nyabinary force-pushed the dorion branch from e3310d7 to 2dec2d6 Compare November 10, 2023 21:20

nyabinary changed the title ~~dorion: 1.2.1 -> 2.2.0~~ dorion: 1.2.1 -> 2.2.1 Nov 10, 2023

nyabinary force-pushed the dorion branch 2 times, most recently from 5c825e5 to 1fd5b9b Compare November 12, 2023 22:47

pbsds reviewed Nov 13, 2023

View reviewed changes

Comment thread pkgs/by-name/do/dorion/package.nix Outdated

Comment thread pkgs/by-name/do/dorion/package.nix Outdated

nyabinary force-pushed the dorion branch 2 times, most recently from 39c423b to 0b33e13 Compare November 13, 2023 15:50

nyabinary requested review from lilyinstarlight and pbsds November 15, 2023 16:22

pbsds reviewed Nov 18, 2023

View reviewed changes

Comment thread pkgs/by-name/do/dorion/package.nix Outdated

Comment thread pkgs/by-name/do/dorion/package.nix Outdated

Comment thread pkgs/by-name/do/dorion/package.nix Outdated

nyabinary force-pushed the dorion branch from 0b33e13 to ad43eee Compare November 18, 2023 21:05

pbsds reviewed Nov 19, 2023

View reviewed changes

Comment thread pkgs/by-name/do/dorion/package.nix Outdated

nyabinary marked this pull request as draft December 19, 2023 15:21

wegank changed the title ~~dorion: 1.2.1 -> 2.2.1~~ dorion: 1.2.1 -> 2.2.1, build from source Jan 3, 2024

wegank mentioned this pull request Jan 3, 2024

Update request: dorion 1.2.1 → 2.1.0 #260737

Closed

1 task

nyabinary force-pushed the dorion branch 2 times, most recently from a1ed935 to 68a67f3 Compare January 12, 2024 15:45

getchoo requested changes Feb 14, 2025

View reviewed changes

griffi-gh mentioned this pull request Feb 18, 2025

luakit: 2.3.3 -> 2.4.0, add maintainer #383092

Merged

13 tasks

SuperSandro2000 reviewed Feb 20, 2025

View reviewed changes

Comment thread pkgs/by-name/do/dorion/package.nix Outdated

nyabinary mentioned this pull request Apr 1, 2025

gupnp-igd: 1.2.0 → 1.6.0; gupnp-igd: refactor; libnice: refactor and switch to gupnp-igd_1_6 #395063

Merged

13 tasks

dorion: 5.0.1 → 6.7.1; dorion: build from source

2f51cb1

Co-authored-by: griffi-gh <prasol258@gmail.com>

getchoo approved these changes May 31, 2025

View reviewed changes

Uh oh!

Uh oh!

Conversation

nyabinary commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

pbsds left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pbsds left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pbsds left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pbsds commented Nov 19, 2023

Uh oh!

nyabinary commented Nov 19, 2023

Uh oh!

Uh oh!

getchoo left a comment

Choose a reason for hiding this comment

Uh oh!

nyabinary commented Feb 14, 2025

Uh oh!

niklaskorz commented Feb 14, 2025

Uh oh!

nyabinary commented Feb 14, 2025

Uh oh!

niklaskorz commented Feb 14, 2025

Uh oh!

nyabinary commented Feb 14, 2025

Uh oh!

Uh oh!

nyabinary commented Mar 15, 2025

Uh oh!

nyabinary commented Apr 1, 2025

Uh oh!

michaelBelsanti commented Apr 22, 2025

Uh oh!

nyabinary commented May 2, 2025

Uh oh!

nyabinary commented May 3, 2025

Uh oh!

michaelBelsanti commented May 4, 2025

Uh oh!

nyabinary commented May 5, 2025

Uh oh!

michaelBelsanti commented May 5, 2025

Uh oh!

nyabinary commented May 6, 2025

Uh oh!

nixos-discourse commented May 13, 2025

Uh oh!

ghost commented May 24, 2025

Uh oh!

nyabinary commented May 26, 2025

Uh oh!

Aleksanaa commented May 26, 2025

Uh oh!

nyabinary commented May 26, 2025

Uh oh!

zzzealed commented May 30, 2025

Uh oh!

PierreBorine commented May 30, 2025

Uh oh!

nyabinary commented May 30, 2025

Uh oh!

getchoo left a comment

nyabinary commented Nov 6, 2023 •

edited

Loading

pbsds left a comment •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`x86_64-linux`