maintainers: add diegs to graphite-cli - #288697
Merged
Merged
Conversation
Contributor
Author
|
@dotlambda FYI |
diegs
force-pushed
the
add-diegs-graphite-cli-maintainer
branch
from
February 14, 2024 01:50
c2042fc to
5898fac
Compare
dotlambda
reviewed
Feb 14, 2024
dotlambda
left a comment
Member
There was a problem hiding this comment.
Let's make it two commits:
maintainers: add diegsgraphite-cli: add diegs to maintainers
diegs
force-pushed
the
add-diegs-graphite-cli-maintainer
branch
from
February 14, 2024 18:29
5898fac to
022f67c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds myself (@diegs) as a maintainer in general and to the graphite-cli package.
Ran both
nix-instantiate --eval maintainers/scripts/check-maintainers-sorted.nixandnix-build lib/tests/maintainers.nixas well as builtgraphite-clito make sure the package syntax is still correct.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.