Skip to content

maintainers: add diegs to graphite-cli - #288697

Merged
dotlambda merged 2 commits into
NixOS:masterfrom
diegs:add-diegs-graphite-cli-maintainer
Feb 15, 2024
Merged

maintainers: add diegs to graphite-cli#288697
dotlambda merged 2 commits into
NixOS:masterfrom
diegs:add-diegs-graphite-cli-maintainer

Conversation

@diegs

@diegs diegs commented Feb 14, 2024

Copy link
Copy Markdown
Contributor

Description of changes

Adds myself (@diegs) as a maintainer in general and to the graphite-cli package.

Ran both nix-instantiate --eval maintainers/scripts/check-maintainers-sorted.nix and nix-build lib/tests/maintainers.nix as well as built graphite-cli to make sure the package syntax is still correct.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@diegs

diegs commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

@dotlambda FYI

@diegs diegs changed the title maintainers: add diegs to graphlite-cli maintainers: add diegs to graphite-cli Feb 14, 2024
@diegs
diegs force-pushed the add-diegs-graphite-cli-maintainer branch from c2042fc to 5898fac Compare February 14, 2024 01:50

@dotlambda dotlambda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it two commits:

  • maintainers: add diegs
  • graphite-cli: add diegs to maintainers

Comment thread maintainers/maintainer-list.nix Outdated
@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 14, 2024
@diegs
diegs force-pushed the add-diegs-graphite-cli-maintainer branch from 5898fac to 022f67c Compare February 14, 2024 18:29
@diegs
diegs requested a review from dotlambda February 14, 2024 18:29
@dotlambda
dotlambda merged commit e4dbabf into NixOS:master Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants