testers.testBuildFailure: fix#375585
Merged
Merged
Conversation
Introduced by cf127c9, which changed default-builder.sh, but forgot to tell testBuildFailure about it.
github-actions
Bot
added
the
6.topic: testing
philiptaron
approved these changes
Jan 21, 2025
Contributor
Author
I wonder whether that ever worked. It sure looks like it should fail, because the succeeds case compares a directory vs a file. I don't understand why that didn't show up in #365347. |
Contributor
|
Me either. I think I ran it!? But it's definitely not right at the present moment, and the test failure makes sense. I merged this PR because I convinced myself it was unrelated. |
Contributor
Author
Agreed. |
2 tasks
GaetanLepage
added a commit
to nix-community/nixvim
that referenced
this pull request
Jan 22, 2025
nix-infra-bot
pushed a commit
to nix-community/nixvim
that referenced
this pull request
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced by cf127c9, which changed default-builder.sh, but forgot to tell testBuildFailure about it.
As reported in #357053 (comment).
Things done
Both
tests.testers.testBuildFailureandtests.stdenv.outputs-no-outpass now. Also grepped fordefault-builder.sh- nobody else uses it, so this PR should fix the issue for good.Add a 👍 reaction to pull requests you find important.