Skip to content

lib.systems: add page size#383756

Open
RossComputerGuy wants to merge 6 commits into
NixOS:stagingfrom
RossComputerGuy:feat/page-size-system
Open

lib.systems: add page size#383756
RossComputerGuy wants to merge 6 commits into
NixOS:stagingfrom
RossComputerGuy:feat/page-size-system

Conversation

@RossComputerGuy
Copy link
Copy Markdown
Member

@RossComputerGuy RossComputerGuy commented Feb 20, 2025 •
edited
Loading

Things done

Adds a new page size platform value. This changes packages like the Linux kernel and jemalloc to switch page sizes easily. When a package does not support a specific page size, it can be marked as broken. The page size system feature comes from NixOS/nix#12446.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: kernel The Linux kernel 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: lib The Nixpkgs function library 6.topic: zig Zig is an imperative, general-purpose, statically typed, compiled system programming language. labels Feb 20, 2025
@RossComputerGuy RossComputerGuy force-pushed the feat/page-size-system branch 3 times, most recently from dc2d230 to d18b238 Compare February 20, 2025 21:12
@github-actions github-actions Bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Feb 20, 2025
@RossComputerGuy RossComputerGuy marked this pull request as draft February 20, 2025 21:23
@RossComputerGuy RossComputerGuy changed the base branch from master to staging February 20, 2025 21:24
@RossComputerGuy RossComputerGuy marked this pull request as ready for review February 20, 2025 21:24
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 16, 2025
@ofborg ofborg Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 18, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 7, 2025
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@philiptaron philiptaron Awaiting requested review from philiptaron

@emilazy emilazy Awaiting requested review from emilazy

@figsoda figsoda Awaiting requested review from figsoda

@reckenrode reckenrode Awaiting requested review from reckenrode

@alyssais alyssais Awaiting requested review from alyssais

@Artturin Artturin Awaiting requested review from Artturin

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: kernel The Linux kernel 6.topic: lib The Nixpkgs function library 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: zig Zig is an imperative, general-purpose, statically typed, compiled system programming language. 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RossComputerGuy @wegank