Skip to content

python3Packages.mocket: disable test_httprettish_httpx_session on darwin#400644

Merged
vcunat merged 1 commit intoNixOS:masterfrom
devusb:fix-mocket-darwin
May 4, 2025
Merged

python3Packages.mocket: disable test_httprettish_httpx_session on darwin#400644
vcunat merged 1 commit intoNixOS:masterfrom
devusb:fix-mocket-darwin

Conversation

@devusb
Copy link
Copy Markdown
Contributor

@devusb devusb commented Apr 21, 2025

Resolves #400373

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 21, 2025
@ofborg ofborg Bot added the 6.topic: darwin Running or building packages on Darwin label Apr 21, 2025
@devusb devusb force-pushed the fix-mocket-darwin branch from 6b02412 to 6bf48c9 Compare April 21, 2025 21:28
@github-actions github-actions Bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 21, 2025
@devusb
Copy link
Copy Markdown
Contributor Author

devusb commented Apr 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 400644


aarch64-darwin

⏩ 10 packages marked as broken and skipped:
  • froide
  • froide-govplan
  • froide-govplan.dist
  • froide.dist
  • python312Packages.froide
  • python312Packages.froide.dist
  • python312Packages.parsedmarc
  • python312Packages.parsedmarc.dist
  • python313Packages.parsedmarc
  • python313Packages.parsedmarc.dist
✅ 54 packages built:
  • ansible (ansible_2_18, python312Packages.ansible-core)
  • ansible-later
  • ansible-later.dist
  • ansible-lint
  • ansible-lint.dist
  • ansible-navigator
  • ansible-navigator.dist
  • ansible.dist (ansible_2_18.dist, python312Packages.ansible-core.dist)
  • ansible_2_16
  • ansible_2_16.dist
  • ansible_2_17
  • ansible_2_17.dist
  • molecule (python312Packages.molecule)
  • molecule.dist (python312Packages.molecule.dist)
  • napalm
  • napalm.dist
  • parsedmarc
  • parsedmarc.dist
  • python312Packages.ansible
  • python312Packages.ansible-compat
  • python312Packages.ansible-compat.dist
  • python312Packages.ansible-kernel
  • python312Packages.ansible-kernel.dist
  • python312Packages.ansible-runner
  • python312Packages.ansible-runner.dist
  • python312Packages.ansible-vault-rw
  • python312Packages.ansible-vault-rw.dist
  • python312Packages.ansible.dist
  • python312Packages.geoip2
  • python312Packages.geoip2.dist
  • python312Packages.mocket
  • python312Packages.mocket.dist
  • python312Packages.msticpy
  • python312Packages.msticpy.dist
  • python312Packages.napalm
  • python312Packages.napalm-hp-procurve
  • python312Packages.napalm-hp-procurve.dist
  • python312Packages.napalm.dist
  • python312Packages.pytest-ansible
  • python312Packages.pytest-ansible.dist
  • python312Packages.pytest-testinfra
  • python312Packages.pytest-testinfra.dist
  • python312Packages.sopel
  • python312Packages.sopel.dist
  • ttp (python312Packages.ttp)
  • ttp.dist (python312Packages.ttp.dist)
  • python313Packages.geoip2
  • python313Packages.geoip2.dist
  • python313Packages.mocket
  • python313Packages.mocket.dist
  • python313Packages.msticpy
  • python313Packages.msticpy.dist
  • python313Packages.sopel
  • python313Packages.sopel.dist

@mayersj1
Copy link
Copy Markdown

Is there a known issue with this test on aarch64-darwin, or are you just commenting out the test because it's failing?

@devusb
Copy link
Copy Markdown
Contributor Author

devusb commented Apr 22, 2025

@mayersj1 I spent maybe 20 minutes looking for an upstream issue and trying to see if there was an obvious reason why it was failing, but didn't find anything conclusive. figured unbreaking all dependent packages was worth just disabling the test, but happy to do something different if you're able to find a way to fix the actual test -- would definitely be preferable.

Comment thread pkgs/development/python-modules/mocket/default.nix Outdated
@XYenon
Copy link
Copy Markdown
Member

XYenon commented Apr 23, 2025

This test failed on x86_64-darwin even without nix.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 23, 2025
@freddydumont
Copy link
Copy Markdown

is there anything blocking a merge for this PR?

@devusb
Copy link
Copy Markdown
Contributor Author

devusb commented Apr 26, 2025

not that I’m aware of.

@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2355

@github-actions github-actions Bot added 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 29, 2025
@devusb devusb force-pushed the fix-mocket-darwin branch from 44f6aff to 6bf48c9 Compare April 29, 2025 03:21
@devusb
Copy link
Copy Markdown
Contributor Author

devusb commented Apr 29, 2025

actually, I take it back -- didn't think through all the rebuilds fixing __darwinAllowLocalNetworking syntax would cause.

I re-limited this PR to only skipping the test -- the other fix will likely need to target staging.

@github-actions github-actions Bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 29, 2025
@booxter
Copy link
Copy Markdown
Contributor

booxter commented Apr 29, 2025

I confirmed the test passed in previous version. Requesting a revert for the bump while we explore what broke it in upstream: #402824

Copy link
Copy Markdown
Contributor

@booxter booxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revert will have to go through staging due to large number of linux rebuilds. This is a good stop-gap until we figure it out to unblock important packages for darwin like ansible.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 29, 2025
@dezren39
Copy link
Copy Markdown
Contributor

dezren39 commented May 2, 2025

any chance we can merge this?

@booxter
Copy link
Copy Markdown
Contributor

booxter commented May 2, 2025

@NixOS/darwin-maintainers

Comment thread pkgs/development/python-modules/mocket/default.nix Outdated
@devusb devusb force-pushed the fix-mocket-darwin branch from 6bf48c9 to 70c1259 Compare May 3, 2025 13:25
@booxter booxter requested a review from khaneliman May 3, 2025 17:17
@booxter
Copy link
Copy Markdown
Contributor

booxter commented May 3, 2025

ZHF: #403336

@booxter booxter added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 3, 2025
@booxter
Copy link
Copy Markdown
Contributor

booxter commented May 3, 2025

FYI this was fixed upstream with: mindflayer/python-mocket@937e625 so we can revert this PR on the next bump.

@vcunat vcunat merged commit f3c9415 into NixOS:master May 4, 2025
27 of 28 checks passed
@devusb devusb deleted the fix-mocket-darwin branch May 4, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: python3.12-mocket

10 participants