python3Packages.mocket: disable test_httprettish_httpx_session on darwin#400644
python3Packages.mocket: disable test_httprettish_httpx_session on darwin#400644vcunat merged 1 commit intoNixOS:masterfrom
Conversation
6b02412 to
6bf48c9
Compare
|
|
Is there a known issue with this test on aarch64-darwin, or are you just commenting out the test because it's failing? |
|
@mayersj1 I spent maybe 20 minutes looking for an upstream issue and trying to see if there was an obvious reason why it was failing, but didn't find anything conclusive. figured unbreaking all dependent packages was worth just disabling the test, but happy to do something different if you're able to find a way to fix the actual test -- would definitely be preferable. |
|
This test failed on x86_64-darwin even without nix. |
|
is there anything blocking a merge for this PR? |
|
not that I’m aware of. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2355 |
44f6aff to
6bf48c9
Compare
|
actually, I take it back -- didn't think through all the rebuilds fixing I re-limited this PR to only skipping the test -- the other fix will likely need to target staging. |
|
I confirmed the test passed in previous version. Requesting a revert for the bump while we explore what broke it in upstream: #402824 |
booxter
left a comment
There was a problem hiding this comment.
The revert will have to go through staging due to large number of linux rebuilds. This is a good stop-gap until we figure it out to unblock important packages for darwin like ansible.
|
any chance we can merge this? |
|
@NixOS/darwin-maintainers |
|
ZHF: #403336 |
|
FYI this was fixed upstream with: mindflayer/python-mocket@937e625 so we can revert this PR on the next bump. |
Resolves #400373
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.