Skip to content

devbox: 0.14.0 -> 0.14.2#402615

Merged
pbsds merged 3 commits intoNixOS:masterfrom
madeddie:devbox-upgrade
May 5, 2025
Merged

devbox: 0.14.0 -> 0.14.2#402615
pbsds merged 3 commits intoNixOS:masterfrom
madeddie:devbox-upgrade

Conversation

@madeddie
Copy link
Copy Markdown
Contributor

@madeddie madeddie commented Apr 28, 2025

A bug was fixed in the current version jetify-com/devbox#2583 that broke devbox in pure mode.

Diff: jetify-com/devbox@0.14.0...0.14.2

I tested this on nix-darwin and nix-on-droid (aarch64-linux in a linux proot under Android).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Apr 28, 2025
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Apr 28, 2025
@github-actions github-actions Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 28, 2025
@nix-owners nix-owners Bot requested review from Lagoja and urandom2 April 28, 2025 20:22
@madeddie
Copy link
Copy Markdown
Contributor Author

madeddie commented Apr 28, 2025

I've found an issue with the build I hadn't run in to before I cleaned out my package cache. The buildGoModule function is having trouble with the go.mod tool section. I see it's been a recent addition to go and it seems the the parser in nixpkgs isn't aware of it yet. I'll see if I can fix it upstream or if I'll add a patch that simply removes this part from go.mod, since it's not required for the build.

@Lagoja
Copy link
Copy Markdown
Contributor

Lagoja commented Apr 28, 2025

This must be pretty recent since I don't believe this is affecting our repo's flake. Thank you for catching and looking into this!

@madeddie
Copy link
Copy Markdown
Contributor Author

It seems the tooling around buildGoModule is using 1.23 on my machines, the tool section of go.mod is new in 1.24. I can't seem to use buildGo124Module for devbox.

@madeddie
Copy link
Copy Markdown
Contributor Author

@madeddie
Copy link
Copy Markdown
Contributor Author

madeddie commented Apr 29, 2025

@Lagoja should I update the references from jetpack.io to jetify.com? I know all the URLs currently redirect, but it might be cleaner?

@Lagoja
Copy link
Copy Markdown
Contributor

Lagoja commented Apr 29, 2025

@madeddie, yes, if you don't mind updating to jetify.com, that would be awesome!

@Lagoja Lagoja closed this Apr 29, 2025
@Lagoja Lagoja reopened this Apr 29, 2025
@madeddie
Copy link
Copy Markdown
Contributor Author

@Lagoja ready for review

@Lagoja
Copy link
Copy Markdown
Contributor

Lagoja commented May 1, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 402615


aarch64-darwin

✅ 1 package built:
  • devbox

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 2, 2025
@pbsds
Copy link
Copy Markdown
Member

pbsds commented May 4, 2025

please rewrite your commits to follow the commit conventions

madeddie added 2 commits May 5, 2025 09:23
Update references for jetpack.io to jetify.com

Project switched to 1.24 in jetify-com/devbox#2533
@madeddie
Copy link
Copy Markdown
Contributor Author

madeddie commented May 5, 2025

@pbsds done

@pbsds pbsds merged commit d4d30b8 into NixOS:master May 5, 2025
29 checks passed
@pbsds
Copy link
Copy Markdown
Member

pbsds commented May 5, 2025

Thank you and welcome to nixpkgs!

Now that you've added yourself to maintainer-list.nix you should in short time be invited to join the nixos/nixpkgs-maintainers group. That invite email will expire in a week. Joining the group will give you additional permissions in nixpkgs, like the ability to change labels on issues and pull requests.

@madeddie madeddie deleted the devbox-upgrade branch May 5, 2025 21:28
@ghost ghost mentioned this pull request May 5, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants