nixos/release: replace amazonImage with amazonConfig#402794
Closed
arianvp wants to merge 1 commit into
Closed
Conversation
Given that we're building the AMIs in https://github.com/NixOS/amis now it's wasteful to store the entire disk image in the cache. We keep building the config that goes *into* the image though so that we can block the channel on regressions.
github-actions
Bot
added
the
6.topic: nixos
Member
Author
|
Need to merge NixOS/amis#262 first but then we can merge this |
github-actions
Bot
added
10.rebuild-darwin: 0
mweinelt
reviewed
Apr 29, 2025
|
|
||
| # A disk image that can be imported to Amazon EC2 and registered as an AMI | ||
| amazonImage = forMatchingSystems [ "x86_64-linux" "aarch64-linux" ] ( | ||
| # The config for A disk image that can be imported to Amazon EC2 and registered as an AMI |
Member
There was a problem hiding this comment.
Suggested change
| # The config for A disk image that can be imported to Amazon EC2 and registered as an AMI | |
| # The config for a disk image that can be imported to Amazon EC2 and registered as an AMI |
vcunat
requested changes
Apr 29, 2025
nixpkgs-ci
Bot
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that we're building the AMIs in https://github.com/NixOS/amis now it's wasteful to store the entire disk image in the cache. We keep building the config that goes into the image though so that we can block the channel on regressions.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.