Skip to content

python312Packages.ipywebrtc: init at 0.6.0#402858

Closed
flokli wants to merge 1 commit into
NixOS:masterfrom
flokli:ipywebrtc
Closed

python312Packages.ipywebrtc: init at 0.6.0#402858
flokli wants to merge 1 commit into
NixOS:masterfrom
flokli:ipywebrtc

Conversation

@flokli

@flokli flokli commented Apr 29, 2025

Copy link
Copy Markdown
Member

This adds ipywebrtc, WebRTC and MediaStream API exposed in the Jupyter notebook/lab.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@flokli flokli requested a review from GaetanLepage April 29, 2025 17:00
@github-actions github-actions Bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 29, 2025
@nix-owners nix-owners Bot requested a review from natsukium April 29, 2025 17:01
@github-actions github-actions Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 29, 2025
@GaetanLepage

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 402858


x86_64-linux

✅ 4 packages built:
  • python312Packages.ipywebrtc
  • python312Packages.ipywebrtc.dist
  • python313Packages.ipywebrtc
  • python313Packages.ipywebrtc.dist

aarch64-linux

✅ 4 packages built:
  • python312Packages.ipywebrtc
  • python312Packages.ipywebrtc.dist
  • python313Packages.ipywebrtc
  • python313Packages.ipywebrtc.dist

x86_64-darwin

✅ 4 packages built:
  • python312Packages.ipywebrtc
  • python312Packages.ipywebrtc.dist
  • python313Packages.ipywebrtc
  • python313Packages.ipywebrtc.dist

aarch64-darwin

✅ 4 packages built:
  • python312Packages.ipywebrtc
  • python312Packages.ipywebrtc.dist
  • python313Packages.ipywebrtc
  • python313Packages.ipywebrtc.dist

pythonImportsCheck = [ "ipywebrtc" ];

meta = {
description = "WebRTC and MediaStream API exposed in the Jupyter notebook/lab.";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "WebRTC and MediaStream API exposed in the Jupyter notebook/lab.";
description = "WebRTC and MediaStream API exposed in the Jupyter notebook/lab";

https://nixos.org/manual/nixpkgs/unstable/#var-meta-description

@flokli

flokli commented Apr 30, 2025

Copy link
Copy Markdown
Member Author

I'm not entirely sure about this one yet. While I've been able to successfully play the big buck bunny video example with it, I've seen some javascript errors suggesting a version incompatibility - the one a source build currently fails with - see https://github.com/NixOS/nixpkgs/pull/402858/files#diff-514d35a40bb9a49adfd365e0078fc2e3569d3351792e046686f2f653a79f0165R17

There's a Jupyter Lab v4 draft PR upstream, it might make sense to wait until upstream is migrated before adding this, or much more testing is needed.

@flokli flokli marked this pull request as draft April 30, 2025 09:19
@flokli

flokli commented Jun 17, 2025

Copy link
Copy Markdown
Member Author

I poked the maintainer of ipywebrtc in the draft PR a second time, but there hasn't been any (code) changes for more than two years.

@GaetanLepage

Copy link
Copy Markdown
Contributor

I poked the maintainer of ipywebrtc in the draft PR a second time, but there hasn't been any (code) changes for more than two years.

Maybe we should not add it indeed.

@flokli

flokli commented Jun 18, 2025

Copy link
Copy Markdown
Member Author

I poked the maintainer of ipywebrtc in the draft PR a second time, but there hasn't been any (code) changes for more than two years.

Maybe we should not add it indeed.

I agree.

@flokli flokli closed this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants