Freecad: fix build with vtk 9.5#421276
Merged
Merged
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
Contributor
|
Is this actually necessary yet? As far as i can tell, vtk is on 9.2.6 and not even your vtk bump (#407910) does 9.5. Also, CI is failing... I'll look at this in more detail later, but some more explanation would be nice. |
Contributor
Author
|
vtk 9.5 draft pr is here. #417613. No idea why CI is failing. |
Contributor
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
Okay, does build, CI passes, and the upstream patch looks reasonable. However...
LordGrimmauld
approved these changes
Jul 1, 2025
nixpkgs-ci
Bot
added
12.approvals: 1
Contributor
Author
|
@LordGrimmauld do you have the right to merge this, i am about to open the draft pr #417613. |
Contributor
|
I do not have commit bit, no. |
Contributor
Author
|
Since the diff is under pkgs/by-name and you are the maintainer of freecad, can you try @nixpkgs-merge-bot . |
Contributor
|
merge bot only works for trusted PR authors, such as r-ryantm |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use vtkUnstructuredGrid::GetLinks instead of vtkUnstructuredGrid::GetCellLinks
See FreeCAD/FreeCAD#22221.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.