Skip to content

stardust-xr-*: <many> -> 0.51.1 & various improvements#457027

Open
Pandapip1 wants to merge 14 commits into
NixOS:masterfrom
Pandapip1:stardust-xr-major-stuff
Open

stardust-xr-*: <many> -> 0.51.1 & various improvements#457027
Pandapip1 wants to merge 14 commits into
NixOS:masterfrom
Pandapip1:stardust-xr-major-stuff

Conversation

@Pandapip1

@Pandapip1 Pandapip1 commented Oct 30, 2025

Copy link
Copy Markdown
Member

"Just" a "small" update/testing PR.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Pandapip1 Pandapip1 changed the title stardust-xr-*: add tests; stardust-xr-server: 0.44.1 -> 0.45.1 stardust-xr-*: add tests and cleanup; stardust-xr-server: 0.44.1 -> 0.45.1 Oct 30, 2025
@Pandapip1 Pandapip1 force-pushed the stardust-xr-major-stuff branch from 6df0683 to 0e4f097 Compare November 7, 2025 03:18
@Pandapip1 Pandapip1 force-pushed the stardust-xr-major-stuff branch 4 times, most recently from 0b9b888 to 4fa0b28 Compare November 7, 2025 10:10
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 13, 2025
@Pandapip1 Pandapip1 force-pushed the stardust-xr-major-stuff branch 2 times, most recently from c6d834c to 9274b00 Compare December 15, 2025 18:56
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 15, 2025
@Pandapip1 Pandapip1 force-pushed the stardust-xr-major-stuff branch from 9274b00 to 62246a6 Compare December 15, 2025 18:59
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 23, 2025
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2026
@Pandapip1 Pandapip1 force-pushed the stardust-xr-major-stuff branch from 38c32ea to e8c0bb4 Compare July 4, 2026 17:58
@nixpkgs-ci nixpkgs-ci Bot removed 2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Jul 4, 2026
@Pandapip1 Pandapip1 force-pushed the stardust-xr-major-stuff branch 8 times, most recently from 49c9273 to db3704a Compare July 5, 2026 03:34
@Pandapip1 Pandapip1 force-pushed the stardust-xr-major-stuff branch from 7d52917 to 1f1fd4f Compare July 5, 2026 03:41
@Pandapip1 Pandapip1 force-pushed the stardust-xr-major-stuff branch 3 times, most recently from e91113b to 63287b3 Compare July 5, 2026 07:04

@Scrumplex Scrumplex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't build any of this but the tests as well as the packages LGTM

Comment thread pkgs/by-name/st/stardust-xr-non-spatial-input/package.nix Outdated
Comment thread pkgs/by-name/st/stardust-xr-server/package.nix Outdated
@Pandapip1 Pandapip1 force-pushed the stardust-xr-major-stuff branch 2 times, most recently from 6c95a3f to e159bd9 Compare July 5, 2026 16:49
@Pandapip1

Copy link
Copy Markdown
Member Author

Also fixed a typo in one of the commits

@Pandapip1 Pandapip1 requested a review from Scrumplex July 5, 2026 16:49
@Pandapip1 Pandapip1 force-pushed the stardust-xr-major-stuff branch 3 times, most recently from 1ef888d to d2cc1f7 Compare July 5, 2026 18:19
@Pandapip1 Pandapip1 force-pushed the stardust-xr-major-stuff branch from d2cc1f7 to 020d438 Compare July 5, 2026 18:22
@Scrumplex

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 457027 --additional-package nixosTests.stardust-xr-atmosphere --additional-package nixosTests.monado --additional-package nixosTests.stardust-xr-flatland
Commit: 5f03ac620b2c54eb22a450b59cde44096afc9c7f


x86_64-linux

✅ 3 tests built:
  • nixosTests.monado
  • nixosTests.stardust-xr-atmosphere
  • nixosTests.stardust-xr-flatland
✅ 7 packages built:
  • stardust-xr-atmosphere
  • stardust-xr-flatland
  • stardust-xr-gravity
  • stardust-xr-non-spatial-input
  • stardust-xr-protostar
  • stardust-xr-server
  • tests.lib-tests

@Pandapip1

Pandapip1 commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

@Scrumplex would you mind re-reviewing? The main changes are that I made a minimal wayland client, packaged it, and used that in test, and also added a patch to the stardust server where it made some incorrect assumptions. There's also the various minor fixes.

@Scrumplex

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 457027 --additional-package nixosTests.stardust-xr-atmosphere --additional-package nixosTests.monado --additional-package nixosTests.stardust-xr-flatland
Commit: 020d4389018295feed4b3c27ef2fc0e436f8f80d


x86_64-linux

✅ 3 tests built:
  • nixosTests.monado
  • nixosTests.stardust-xr-atmosphere
  • nixosTests.stardust-xr-flatland
✅ 8 packages built:
  • stardust-xr-atmosphere
  • stardust-xr-flatland
  • stardust-xr-gravity
  • stardust-xr-non-spatial-input
  • stardust-xr-protostar
  • stardust-xr-server
  • tests.lib-tests
  • wayland-colorbar

@Pandapip1

Copy link
Copy Markdown
Member Author

I moreso meant the diff itself, sorry.

@nixos-discourse

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/7202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: teams Relating to team creation, updates, other management actions 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants