Skip to content

nim: remove nim1 EOL#460946

Closed
Eveeifyeve wants to merge 2 commits into
NixOS:masterfrom
Eveeifyeve:remove-nim-1
Closed

nim: remove nim1 EOL#460946
Eveeifyeve wants to merge 2 commits into
NixOS:masterfrom
Eveeifyeve:remove-nim-1

Conversation

@Eveeifyeve

@Eveeifyeve Eveeifyeve commented Nov 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Deprecates nim1 it has been EOL for a while.
Checks feature freeze: #444721

@leona-ya Has approved this to happen in matrix chat: https://matrix.to/#/!aGqRytqbCECitOFhbt:nixos.org/$qZg_7i_H2Lbja-O9PncEE29jOGdpI6hieV-z9qFy3po?via=nixos.org&via=matrix.org&via=leona.is

Links: #460877

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

CC @NixOS/nim & @jbedo (mosdepth maintainer)

Add a 👍 reaction to pull requests you find important.

@Eveeifyeve Eveeifyeve changed the title vimPlugins.fruzzy: build using nim2 nim: remove nim1 EOL Nov 12, 2025
@Eveeifyeve Eveeifyeve mentioned this pull request Nov 12, 2025
Open
17 tasks
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 8.has: changelog This PR adds or changes release notes 6.topic: vim Advanced text editor 6.topic: nim Nim programing language 8.has: documentation This PR adds or changes documentation labels Nov 12, 2025
eclairevoyant
eclairevoyant suggested changes Nov 12, 2025
View reviewed changes

@eclairevoyant eclairevoyant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also as CI mentioned, please nixfmt the files that were changed.

Comment thread pkgs/top-level/aliases.nix Outdated
Comment thread pkgs/by-name/ni/nim-unwrapped-2_0/package.nix Outdated
Comment thread pkgs/by-name/ni/nim-unwrapped-2_0/package.nix Outdated
Comment thread doc/release-notes/rl-2511.section.md
@@ -108,6 +108,8 @@

- `cudaPackages.cudatoolkit-legacy-runfile` has been removed.

- `nim1` and respective aliases has been removed due to EOL, please use nim.

@eclairevoyant eclairevoyant Nov 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an upstream announcement we can link to?

@Eveeifyeve Eveeifyeve Nov 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, as nim versions it stuff as main and patch release after patch release it's eol.

Please see https://nim-lang.org/blog.html

@daylinmorgan daylinmorgan Nov 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like they've switched terminology from LTS release to "stable" release as well.

@Eveeifyeve Eveeifyeve force-pushed the remove-nim-1 branch 3 times, most recently from 653c616 to 4009b07 Compare November 12, 2025 15:19
@PerchunPak PerchunPak mentioned this pull request Nov 12, 2025
Merged
13 tasks
PerchunPak
PerchunPak reviewed Nov 12, 2025
View reviewed changes
Comment thread pkgs/applications/editors/vim/plugins/overrides.nix Outdated
@eclairevoyant

eclairevoyant commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

We can drop the 2d4c4d07e1017324086e85cfe1e041d407f5b714 commit since the other PR was merged. Otherwise this seems fine.

@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 12, 2025
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 13, 2025
@Eveeifyeve
nim1: remove
dfbe568 
Co-authored-by: éclairevoyant
<848000+eclairevoyant@users.noreply.github.com>
@Eveeifyeve
mosdepth: build using nim2
cb5cf9c
@GaetanLepage

GaetanLepage commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

Evaluation is failing.

@Eveeifyeve

Eveeifyeve commented Nov 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

I have received a response that nim1 is in LTS mode and is still getting patches.
I will be making another pr moving the lts versions to nim-lts and nim2 to nim.

Users should be aiming to migrate to nim 2 as soon as possible.

Please read this for more info: https://matrix.to/#/!NtPGCsIuIJTmoxqwHM:matrix.org/$-mqvqmTFNEF_wPqmJ4rPOyMPE92wBuxV7BnkhqEORyk?via=matrix.org&via=t2bot.io&via=envs.net

EDIT: I have also updated this list: #460877 (comment) to reflect on the changes needed

@Eveeifyeve Eveeifyeve closed this Nov 13, 2025
@GaetanLepage

GaetanLepage commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

I have received a response that nim1 is in LTS mode and is still getting patches. I will be making another pr moving the lts versions to nim-lts and nim2 to nim.

Users should be aiming to migrate to nim 2 as soon as possible.

Please read this for more info: https://matrix.to/#/!NtPGCsIuIJTmoxqwHM:matrix.org/$-mqvqmTFNEF_wPqmJ4rPOyMPE92wBuxV7BnkhqEORyk?via=matrix.org&via=t2bot.io&via=envs.net

Ok thanks!

@Eveeifyeve

Eveeifyeve commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Nim 1 is not in lts. I made the wrong comment, coming back to this. Anyways I made a better pr here #461756

@Eveeifyeve Eveeifyeve deleted the remove-nim-1 branch January 22, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GaetanLepage GaetanLepage Awaiting requested review from GaetanLepage
@jbedo jbedo Awaiting requested review from jbedo
@khaneliman khaneliman Awaiting requested review from khaneliman
@mrcjkb mrcjkb Awaiting requested review from mrcjkb
@philiptaron philiptaron Awaiting requested review from philiptaron
@daylinmorgan daylinmorgan Awaiting requested review from daylinmorgan
@eclairevoyant eclairevoyant Awaiting requested review from eclairevoyant
1 more reviewer
@PerchunPak PerchunPak PerchunPak left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nim Nim programing language 6.topic: vim Advanced text editor 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Eveeifyeve @eclairevoyant @GaetanLepage @daylinmorgan @PerchunPak