nim: huge refactor of versioning#461756
Conversation
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as resolved.
This comment was marked as resolved.
d2aaa56 to
ba51739
Compare
ba51739 to
7e6d314
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bc14daf to
1d61b2c
Compare
1d61b2c to
b08a096
Compare
This comment was marked as resolved.
This comment was marked as resolved.
The problem is you're unconditionally setting |
eef2235 to
6765fa2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Upgrade: same with nimlsp nim was upgraded and removed this now defaults to nim which is currently 2.2.6 Broken: NixOS#461756 (comment) Upstream needs updating their nim versions for now, it will be marked broken
fd109be to
1e4ca06
Compare
1e4ca06 to
a360854
Compare
a360854 to
3937c15
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Looks like mosdepth is broken |
3937c15 to
b278daf
Compare
eclairevoyant
left a comment
There was a problem hiding this comment.
Again, not sure why it was moved in the first place.
|
I can't seem to request a review from you, @eclairevoyant. I want you to review this as well. |
|
FYI 2.2.8 was released: https://nim-lang.org/blog/2026/02/23/nim-228.html |
|
I am going to add this to the 26.05 issue as the aim should be, nim 1 and nim 2.0 versions to be deprecated by 26.05. |
Current active issue with this is it won't build due to: UPDATE it's failing at the |
|
Building 2.2.8 with I tested this in a container and ran into the same issue so it's not Removing the |
|
Fuck, I just control alt deleted this by accident. I have a backup branch, I will rebase on to that branch. |
|
I have this branch up to yesterday I think |
Deprecates nim1 and nim2 and respective unwrap packages packages and mainstreams one version of nim and respective unwrap which is upgraded to 2.2.8 and fixes nim pname issue in #485742.
Changelog: https://nim-lang.org/blog/2026/02/23/nim-228.html
Currently broken see: #461756 (comment)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.