Skip to content

nim: huge refactor of versioning#461756

Closed
Eveeifyeve wants to merge 0 commit into
NixOS:masterfrom
Eveeifyeve:nim-refractor-1
Closed

nim: huge refactor of versioning#461756
Eveeifyeve wants to merge 0 commit into
NixOS:masterfrom
Eveeifyeve:nim-refractor-1

Conversation

@Eveeifyeve
Copy link
Copy Markdown
Member

@Eveeifyeve Eveeifyeve commented Nov 14, 2025

Deprecates nim1 and nim2 and respective unwrap packages packages and mainstreams one version of nim and respective unwrap which is upgraded to 2.2.8 and fixes nim pname issue in #485742.

Changelog: https://nim-lang.org/blog/2026/02/23/nim-228.html

Currently broken see: #461756 (comment)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 18, 2025
@Eveeifyeve

This comment was marked as spam.

@Eveeifyeve

This comment was marked as resolved.

@Eveeifyeve Eveeifyeve force-pushed the nim-refractor-1 branch 2 times, most recently from d2aaa56 to ba51739 Compare November 27, 2025 02:26
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 27, 2025
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 29, 2025
@Eveeifyeve

This comment was marked as outdated.

@Eveeifyeve Eveeifyeve marked this pull request as ready for review November 30, 2025 09:49
@Eveeifyeve Eveeifyeve force-pushed the nim-refractor-1 branch 4 times, most recently from bc14daf to 1d61b2c Compare November 30, 2025 13:40
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 30, 2025
@Eveeifyeve

This comment was marked as resolved.

@eclairevoyant
Copy link
Copy Markdown
Contributor

eclairevoyant commented Nov 30, 2025

evaluation warning: warning: requiredNimVersion is deprecated and will be removed in a future release; please update your configuration.

The problem is you're unconditionally setting requiredNimVersion so this warning will always be present.

Comment thread pkgs/build-support/build-nim-package.nix Outdated
@Eveeifyeve Eveeifyeve force-pushed the nim-refractor-1 branch 3 times, most recently from eef2235 to 6765fa2 Compare November 30, 2025 15:20
Comment thread pkgs/build-support/build-nim-package.nix Outdated
Comment thread pkgs/build-support/build-nim-package.nix Outdated
Comment thread pkgs/build-support/build-nim-package.nix Outdated
@eclairevoyant eclairevoyant added 8.has: clean-up This PR removes packages or removes other cruft 6.topic: nim Nim programing language labels Nov 30, 2025
@Eveeifyeve

This comment was marked as resolved.

@Eveeifyeve

This comment was marked as resolved.

@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 13, 2025
Eveeifyeve added a commit to Eveeifyeve/nixpkgs that referenced this pull request Jan 10, 2026
Upgrade: same with nimlsp nim was upgraded and removed this now defaults
to nim which is currently 2.2.6

Broken:
NixOS#461756 (comment)
Upstream needs updating their nim versions for now, it will be marked
broken
@Eveeifyeve Eveeifyeve force-pushed the nim-refractor-1 branch 2 times, most recently from fd109be to 1e4ca06 Compare January 10, 2026 11:25
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 10, 2026
@eclairevoyant
Copy link
Copy Markdown
Contributor

eclairevoyant commented Jan 10, 2026

The nph commit fd109be is missing from the PR, as is e994a18.

@nixpkgs-ci nixpkgs-ci Bot removed the 6.topic: vim Advanced text editor label Jan 11, 2026
@Eveeifyeve

This comment was marked as resolved.

@eclairevoyant
Copy link
Copy Markdown
Contributor

Looks like mosdepth is broken

Copy link
Copy Markdown
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, not sure why it was moved in the first place.

Comment thread pkgs/build-support/build-nim-package.nix Outdated
@Eveeifyeve
Copy link
Copy Markdown
Member Author

Eveeifyeve commented Feb 15, 2026

I can't seem to request a review from you, @eclairevoyant. I want you to review this as well.

Comment thread doc/release-notes/rl-2605.section.md
Comment thread pkgs/top-level/aliases.nix Outdated
@daylinmorgan
Copy link
Copy Markdown
Contributor

FYI 2.2.8 was released: https://nim-lang.org/blog/2026/02/23/nim-228.html

@Eveeifyeve
Copy link
Copy Markdown
Member Author

I am going to add this to the 26.05 issue as the aim should be, nim 1 and nim 2.0 versions to be deprecated by 26.05.

@Eveeifyeve
Copy link
Copy Markdown
Member Author

Eveeifyeve commented Mar 4, 2026

FYI 2.2.8 was released: nim-lang.org/blog/2026/02/23/nim-228.html

Current active issue with this is it won't build due to:

CC: koch.nim
Hint:  [Link]
Hint: mm: orc; threads: on; opt: none (DEBUG BUILD, `-d:release` generates faster code)
70624 lines; 3.099s; 113.281MiB peakmem; proj: koch; out: /nix/var/nix/builds/nix-44862-3842090379/nim-2.2.8/koch [Succes
sX]
iteration: 1
bin/nim c  --skipUserCfg --skipParentCfg -d:nimKochBootstrap --nimcache:nimcache/r_macosx_arm64 --cpu:arm64 --os:MacOSX -
d:release -d:useGnuReadline -d:nativeStacktrace --parallelBuild:10 --noNimblePath --compileOnly compiler/nim.nim
Hint: used config file '/nix/var/nix/builds/nix-44862-3842090379/nim-2.2.8/config/nim.cfg' [Conf]
Hint: used config file '/nix/var/nix/builds/nix-44862-3842090379/nim-2.2.8/config/config.nims' [Conf]
Hint: used config file '/nix/var/nix/builds/nix-44862-3842090379/nim-2.2.8/compiler/nim.cfg' [Conf]
...............................
/nix/var/nix/builds/nix-44862-3842090379/nim-2.2.8/lib/system/excpt.nim(214, 14) Error: type mismatch
Expression: add(s, tempDlInfo.dli_fname)
  [1] s: string
  [2] tempDlInfo.dli_fname: cstring

Expected one of (first mismatch at [position]):
[1] proc add[T](s: var CellSeq[T]; c: T; t: PNimTypeV2)
[1] proc add[T](x: var seq[T]; y: openArray[T])
[1] proc add[T](x: var seq[T]; y: sink T)
[2] proc add(x: var string; y: char)
[2] proc add(x: var string; y: string)

UPDATE it's failing at the koch boot.

@daylinmorgan
Copy link
Copy Markdown
Contributor

Building 2.2.8 with -d:release and -d:nativeStackTrace is causing this. This is still the case if you build the bootstrapped nim from source using sh build.sh (which we should be doing anyways, but that's unrelated).

I tested this in a container and ran into the same issue so it's not nix-specific.

Removing -d:nativeStackTrace would resolve the build issue (but I assume it was added for a reason).

the useGnuReadline and nativeStackTrace flags were seemingly added in 2017 and have stuck around, but I don't know if we need or should use either of them: 4e0a5e7

@Eveeifyeve
Copy link
Copy Markdown
Member Author

Eveeifyeve commented Mar 5, 2026

Fuck, I just control alt deleted this by accident. I have a backup branch, I will rebase on to that branch.

@daylinmorgan
Copy link
Copy Markdown
Contributor

I have this branch up to yesterday I think

@daylinmorgan
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nim Nim programing language 8.has: changelog This PR adds or changes release notes 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants