Skip to content

python3Packages.plotly: cleanup, fix build#493484

Closed
GaetanLepage wants to merge 1 commit intoNixOS:masterfrom
GaetanLepage:plotly
Closed

python3Packages.plotly: cleanup, fix build#493484
GaetanLepage wants to merge 1 commit intoNixOS:masterfrom
GaetanLepage:plotly

Conversation

@GaetanLepage
Copy link
Copy Markdown
Contributor

@GaetanLepage GaetanLepage commented Feb 23, 2026

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested review from Pandapip1 and sarahec February 23, 2026 23:55
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Feb 23, 2026
@GaetanLepage GaetanLepage force-pushed the plotly branch 5 times, most recently from 7fb4c06 to 2c2e978 Compare February 24, 2026 00:06
@sarahec
Copy link
Copy Markdown
Contributor

sarahec commented Feb 24, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 493484 --package python3Packages.plotly --package python314Packages.plotly
Commit: 54aaebe26900065491743fd95ed3429fcea24125

x86_64-linux

✅ 4 packages built:
  • python314Packages.plotly
  • python314Packages.plotly.dist (python314Packages.plotly.dist.dist)
  • python3Packages.plotly
  • python3Packages.plotly.dist (python3Packages.plotly.dist.dist)

sarahec
sarahec approved these changes Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sarahec sarahec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahec
Copy link
Copy Markdown
Contributor

sarahec commented Feb 24, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 493484 --package python3Packages.plotly --package python314Packages.plotly
Commit: 54aaebe26900065491743fd95ed3429fcea24125

aarch64-darwin

✅ 4 packages built:
  • python314Packages.plotly
  • python314Packages.plotly.dist (python314Packages.plotly.dist.dist)
  • python3Packages.plotly
  • python3Packages.plotly.dist (python3Packages.plotly.dist.dist)

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 24, 2026
Pandapip1
Pandapip1 approved these changes Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM from me

@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Feb 24, 2026

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2826

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 24, 2026
@Pandapip1 Pandapip1 mentioned this pull request Feb 24, 2026
Closed
3 tasks
@elisaado
Copy link
Copy Markdown

elisaado commented Feb 24, 2026 •
edited
Loading

Hi, the build still seems to fail on aarch64-linux with python3.13-plotly-6.5.2 from this branch. The package builds correctly, then tries to run tests, and then crashes or gets killed;

/nix/store/34a9zlxnaq23x3rnfwr3xlac9nkmdvr8-pytest-check-hook/nix-support/setup-hook: line 23:  5088 Aborted                    (core dumped) /nix/store/jbxc3f1gbnnx5wwhby9z56w95k44n0sw-python3-3.13.12/bin/python3.....

Edit: ah, found the issue that's preventing the tests (and thus the build) from finishing on aarch64-linux

plotly> <jemalloc>: Unsupported system page size

@thunze
Copy link
Copy Markdown
Member

thunze commented Feb 24, 2026

FYI I opened #493409 before with proper patches and did the necessary upstream work

@GaetanLepage
Copy link
Copy Markdown
Contributor Author

GaetanLepage commented Feb 24, 2026

Closing in favor of #493409.

@GaetanLepage GaetanLepage deleted the plotly branch February 24, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sarahec sarahec sarahec approved these changes

@Pandapip1 Pandapip1 Pandapip1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GaetanLepage @sarahec @nixos-discourse @elisaado @thunze @Pandapip1