Skip to content

python3Packages.plotly: fix pytest 9 collection and numpy2 test failures #494436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amaanq wants to merge 1 commit into from
Closed

python3Packages.plotly: fix pytest 9 collection and numpy2 test failures #494436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions pkgs/development/python-modules/plotly/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,19 @@ buildPythonPackage rec {
substituteInPlace pyproject.toml \
--replace-fail '"hatch", ' "" \
--replace-fail "jupyter_packaging~=0.10.0" jupyter_packaging

# pytest 9 removed the legacy `path` (py.path.local) hook parameter;
# rename to `collection_path` (pathlib.Path) which works the same way
# since the function already calls str() on it.
substituteInPlace plotly/conftest.py \
--replace-fail "def pytest_ignore_collect(path):" \
"def pytest_ignore_collect(collection_path):" \
--replace-fail "os.path.basename(str(path))" \
"os.path.basename(str(collection_path))" \
--replace-fail 'or "plotly/plotly/plotly/__init__.py" in str(path)' \
'or "plotly/plotly/plotly/__init__.py" in str(collection_path)' \
--replace-fail 'or "plotly/api/utils.py" in str(path)' \
'or "plotly/api/utils.py" in str(collection_path)'
'';

env.SKIP_NPM = true;
Expand Down Expand Up @@ -104,6 +117,10 @@ buildPythonPackage rec {
"test_acceptance_named"
# AssertionError: assert '' == 'browser'
"test_default_renderer"
# numpy 2 removed np.in1d and the `interpolation` kwarg from percentile
"test_violin_fig"
"test_custom_data_scatter"
"test_sunburst_treemap_with_path_color"
];

__darwinAllowLocalNetworking = true;
Expand Down
Loading