Skip to content

top-level/by-name-overlay: set meta.position - #498346

Closed
rhendric wants to merge 7 commits into
NixOS:masterfrom
rhendric:rhendric/by-name-meta.position
Closed

top-level/by-name-overlay: set meta.position#498346
rhendric wants to merge 7 commits into
NixOS:masterfrom
rhendric:rhendric/by-name-meta.position

Conversation

@rhendric

@rhendric rhendric commented Mar 9, 2026

Copy link
Copy Markdown
Member

Inspired by #495822, which morally ought to have worked, but of course could not because all the meta.positions point to the same file.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@rhendric
rhendric force-pushed the rhendric/by-name-meta.position branch 3 times, most recently from 9a0f9f0 to 3934483 Compare March 9, 2026 21:23
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: stdenv Standard environment labels Mar 9, 2026
@rhendric
rhendric marked this pull request as ready for review March 9, 2026 21:29
@rhendric
rhendric requested a review from infinisil March 9, 2026 21:33
@nixpkgs-ci
nixpkgs-ci Bot requested review from a team, Ericson2314, adisbladis and philiptaron March 9, 2026 21:41
infinisil
infinisil reviewed Mar 9, 2026
View reviewed changes
Comment thread pkgs/top-level/by-name-overlay.nix
@rhendric
rhendric marked this pull request as draft March 9, 2026 21:46
@rhendric
rhendric force-pushed the rhendric/by-name-meta.position branch from 3934483 to 416f72d Compare March 10, 2026 03:51
github-actions[bot]

This comment was marked as outdated.

Sign in to view

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 10, 2026
@rhendric
rhendric force-pushed the rhendric/by-name-meta.position branch from 416f72d to 88058c4 Compare March 10, 2026 05:32
@nixpkgs-ci nixpkgs-ci Bot removed the 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. label Mar 10, 2026
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: stdenv Standard environment labels Mar 10, 2026
@nixpkgs-ci nixpkgs-ci Bot added the 6.topic: stdenv Standard environment label Mar 10, 2026
@rhendric
rhendric marked this pull request as ready for review March 10, 2026 10:08
@anna-oake anna-oake mentioned this pull request Mar 10, 2026
Draft
@rhendric rhendric mentioned this pull request Mar 12, 2026
Draft
13 tasks
@rhendric rhendric closed this Mar 12, 2026
@github-project-automation github-project-automation Bot moved this to Done in Stdenv Mar 12, 2026
@rhendric
rhendric deleted the rhendric/by-name-meta.position branch March 12, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infinisil infinisil infinisil left review comments
@github-actions github-actions[bot] github-actions[bot] left review comments
@adisbladis adisbladis Awaiting requested review from adisbladis
@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314
@philiptaron philiptaron Awaiting requested review from philiptaron
@ilyakooo0 ilyakooo0 Awaiting requested review from ilyakooo0
@OPNA2608 OPNA2608 Awaiting requested review from OPNA2608
@Pandapip1 Pandapip1 Awaiting requested review from Pandapip1
@roberth roberth Awaiting requested review from roberth

Assignees

No one assigned

Labels

6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

Stdenv
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rhendric @infinisil