pkgsStatic.llhttp: fix building static archives#500733
Merged
Merged
Conversation
The cmake options were changed in nodejs/llhttp@b671ac1. This should unbreak `nixStatic`.
nixpkgs-ci
Bot
added
10.rebuild-linux: 501+
Contributor
|
Note: this is due to nodejs/llhttp#657, released with v9.3.1 that landed with d650240 |
aduh95
reviewed
Mar 17, 2026
aduh95
approved these changes
Mar 17, 2026
aduh95
left a comment
aduh95
left a comment
Contributor
There was a problem hiding this comment.
Builds on darwin-aarch64 when rebased on top of staging-next
nixpkgs-ci
Bot
added
12.approvals: 1
13 tasks
3 tasks
13 tasks
sarahec
pushed a commit
to sarahec/nixpkgs
that referenced
this pull request
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.