Skip to content

Split silverbullet#511573

Closed
bobvanderlinden wants to merge 2 commits intoNixOS:masterfrom
bobvanderlinden:split-silverbullet
Closed

Split silverbullet#511573
bobvanderlinden wants to merge 2 commits intoNixOS:masterfrom
bobvanderlinden:split-silverbullet

Conversation

@bobvanderlinden
Copy link
Copy Markdown
Member

Silverbullet 2.6.1 now has a server and a cli. See https://github.com/silverbulletmd/silverbullet/releases/tag/2.6.1.

This PR renames the silverbullet package to silverbullet-server and introduces silverbullet-cli. Both still rely on the shipped binary instead of building it ourselves.

I've deprecated silverbullet package with a suggestion to use silverbullet-server.

I was contemplating using the silverbullet-cli for the tests of silverbullet-server, but it doesn't seem to support the default 'space' and its cli is still considered experimental. I'd gather the subcommands and arguments will likely change.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested a review from aorith April 19, 2026 21:51
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (new) This PR adds a new package 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 19, 2026
@donovanglover
Copy link
Copy Markdown
Member

There is an older PR #510825 that builds silverbullet-cli from source.

silverbullet-server seems unnecessary since server is assumed, similar to jellyfin.

@gleber
Copy link
Copy Markdown
Contributor

gleber commented Apr 21, 2026

#510825 is alive and kicking... er... waiting for a reviewer :)

@gleber
Copy link
Copy Markdown
Contributor

gleber commented Apr 21, 2026

FWIW, I did a quick vibecoding pass on moving silverbullet package to source build:
https://github.com/gleber/nixpkgs/blob/0fc1af7b7f54d72afdcaeec527c649048cbfe90b/pkgs/by-name/si/silverbullet/package.nix

But haven't created a PR for it yet. I have no strong preference which exact PR goes in and in which order they go in - as long as in the end we have all silverbullet stuff in nixpkgs and done according to best practices :)

@aorith
Copy link
Copy Markdown
Member

aorith commented Apr 22, 2026

Thanks @bobvanderlinden, personally I agree with @donovanglover in that having silverbullet for the "main" app/server and silverbullet-cli for the new CLI is already fine.

That said, upstream has recently moved away from a Deno2 setup to a mix of Node and Go, that should make nixos packaging from sources easier, that is if they do not change it again in the coming months :D

@bobvanderlinden
Copy link
Copy Markdown
Member Author

Ah nice, the other PR looks good to me 👍 closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants