Conversation
|
#510825 is alive and kicking... er... waiting for a reviewer :) |
|
FWIW, I did a quick vibecoding pass on moving silverbullet package to source build: But haven't created a PR for it yet. I have no strong preference which exact PR goes in and in which order they go in - as long as in the end we have all silverbullet stuff in nixpkgs and done according to best practices :) |
|
Thanks @bobvanderlinden, personally I agree with @donovanglover in that having That said, upstream has recently moved away from a Deno2 setup to a mix of Node and Go, that should make nixos packaging from sources easier, that is if they do not change it again in the coming months :D |
|
Ah nice, the other PR looks good to me 👍 closing this one |
Silverbullet 2.6.1 now has a server and a cli. See https://github.com/silverbulletmd/silverbullet/releases/tag/2.6.1.
This PR renames the
silverbulletpackage tosilverbullet-serverand introducessilverbullet-cli. Both still rely on the shipped binary instead of building it ourselves.I've deprecated
silverbulletpackage with a suggestion to usesilverbullet-server.I was contemplating using the
silverbullet-clifor the tests ofsilverbullet-server, but it doesn't seem to support the default 'space' and its cli is still considered experimental. I'd gather the subcommands and arguments will likely change.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.