hickory-dns: Enable systemd and prometheus-metrics features#511575
hickory-dns: Enable systemd and prometheus-metrics features#511575jpds wants to merge 3 commits intoNixOS:masterfrom
Conversation
jpds
force-pushed
the
hickory-dns-systemd-prometheus-metrics
branch
2 times, most recently
from
34cb396 to
175f2cb
Compare
jpds
force-pushed
the
hickory-dns-systemd-prometheus-metrics
branch
from
175f2cb to
c456109
Compare
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
uninsane
left a comment
uninsane
left a comment
There was a problem hiding this comment.
i think we only need to test with one resolver (e.g. only resolve or kdig, but probably not both). otherwise we're blurring the line between testing the nixos service/integration, v.s. testing hickory-dns's internals.
also that parsing of resolve's output looks fragile/liable to break across any update to the package should they change the formatting. i wouldn't parse that unless there's some flag to ask for machine-readable output.
| host: str, | ||
| query_type: str, | ||
| name: str, | ||
| expected: typing.Optional[str] = None, |
There was a problem hiding this comment.
| expected: typing.Optional[str] = None, | |
| expected: str, |
this is never called with expected = None AFAICT.
| { pkgs, lib, ... }: | ||
|
|
||
| let | ||
| cert = pkgs.runCommand "selfSignedCerts" { buildInputs = [ pkgs.openssl ]; } '' |
There was a problem hiding this comment.
| cert = pkgs.runCommand "selfSignedCerts" { buildInputs = [ pkgs.openssl ]; } '' | |
| cert = pkgs.runCommand "selfSignedCerts" { nativeBuildInputs = [ pkgs.openssl ]; } '' |
| host: str, | ||
| query_type: str, | ||
| name: str, | ||
| expected: typing.Optional[str] = None, |
There was a problem hiding this comment.
| expected: typing.Optional[str] = None, | |
| expected: str, |
this is never called with expected = None AFAICT.
We landed a different fix in hickory-dns/hickory-dns#3611 that should address the issue equivalently. |
3 participants
Default enable systemd and prometheus-metrics features in hickory-dns. checkFeatures can be removed once hickory-dns/hickory-dns#3599 lands.
Also add an integration test that validates client output against two resolver implementations.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.