Skip to content

skypilot: 0.8.1 -> 0.12.0#511582

Merged
GaetanLepage merged 4 commits intoNixOS:masterfrom
daspk04:update-skypilot
Apr 20, 2026
Merged

skypilot: 0.8.1 -> 0.12.0#511582
GaetanLepage merged 4 commits intoNixOS:masterfrom
daspk04:update-skypilot

Conversation

@daspk04
Copy link
Copy Markdown
Contributor

@daspk04 daspk04 commented Apr 19, 2026 •
edited
Loading

Things done

  1. Updated skypilot to latest version (0.12.0) as 0.8.1 is quite old.
  2. Added 2 new python packages which were required for skypilot: types-paramiko and sqlalchemy-adapter (2 separate commit)
  3. Some of the optional dependencies are missing in nixpkgs but can be added later
  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested review from natsukium and seanrmurphy April 19, 2026 22:31
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Apr 19, 2026
@daspk04 daspk04 requested a review from GaetanLepage April 19, 2026 22:33
GaetanLepage
GaetanLepage reviewed Apr 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!
I made a few comments.

Comment thread pkgs/development/python-modules/sqlalchemy-adapter/default.nix
Comment thread pkgs/development/python-modules/sqlalchemy-adapter/default.nix
Comment thread pkgs/development/python-modules/types-paramiko/default.nix Outdated
Comment thread pkgs/development/python-modules/types-paramiko/default.nix
Comment thread pkgs/by-name/sk/skypilot/package.nix Outdated
@daspk04
Copy link
Copy Markdown
Contributor Author

daspk04 commented Apr 19, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 511582
Commit: da1419a7c39dc173baf4ae06f2a6f6cb95d01a1a (subsequent changes)
Merge: 2543d94653c07493c7f0bb91f7442023c2e4ea48

Logs: https://github.com/daspk04/nixpkgs-review-gha/actions/runs/24640776901

x86_64-linux

✅ 10 packages built:
  • python313Packages.sqlalchemy-adapter
  • python313Packages.sqlalchemy-adapter.dist
  • python313Packages.types-paramiko
  • python313Packages.types-paramiko.dist
  • python314Packages.sqlalchemy-adapter
  • python314Packages.sqlalchemy-adapter.dist
  • python314Packages.types-paramiko
  • python314Packages.types-paramiko.dist
  • skypilot
  • skypilot.dist

aarch64-linux

✅ 10 packages built:
  • python313Packages.sqlalchemy-adapter
  • python313Packages.sqlalchemy-adapter.dist
  • python313Packages.types-paramiko
  • python313Packages.types-paramiko.dist
  • python314Packages.sqlalchemy-adapter
  • python314Packages.sqlalchemy-adapter.dist
  • python314Packages.types-paramiko
  • python314Packages.types-paramiko.dist
  • skypilot
  • skypilot.dist

x86_64-darwin (sandbox = relaxed)

✅ 10 packages built:
  • python313Packages.sqlalchemy-adapter
  • python313Packages.sqlalchemy-adapter.dist
  • python313Packages.types-paramiko
  • python313Packages.types-paramiko.dist
  • python314Packages.sqlalchemy-adapter
  • python314Packages.sqlalchemy-adapter.dist
  • python314Packages.types-paramiko
  • python314Packages.types-paramiko.dist
  • skypilot
  • skypilot.dist

aarch64-darwin (sandbox = relaxed)

✅ 10 packages built:
  • python313Packages.sqlalchemy-adapter
  • python313Packages.sqlalchemy-adapter.dist
  • python313Packages.types-paramiko
  • python313Packages.types-paramiko.dist
  • python314Packages.sqlalchemy-adapter
  • python314Packages.sqlalchemy-adapter.dist
  • python314Packages.types-paramiko
  • python314Packages.types-paramiko.dist
  • skypilot
  • skypilot.dist

GaetanLepage
GaetanLepage reviewed Apr 19, 2026
View reviewed changes
Comment thread pkgs/by-name/sk/skypilot/package.nix
types-paramiko
typing-extensions
uvicorn
wheel
Copy link
Copy Markdown
Contributor

@GaetanLepage GaetanLepage Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure wheel is a dependency?

Copy link
Copy Markdown
Contributor Author

@daspk04 daspk04 Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think yes c.f, without it this related utils would fail on cluster I assume.

Comment thread pkgs/by-name/sk/skypilot/package.nix Outdated
Comment thread pkgs/by-name/sk/skypilot/package.nix
@GaetanLepage
Copy link
Copy Markdown
Contributor

GaetanLepage commented Apr 20, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 511582
Commit: be48fe65306b17ff5712f2f8f0e3fdf30c97ac90

x86_64-linux

✅ 10 packages built:
  • python313Packages.sqlalchemy-adapter
  • python313Packages.sqlalchemy-adapter.dist
  • python313Packages.types-paramiko
  • python313Packages.types-paramiko.dist
  • python314Packages.sqlalchemy-adapter
  • python314Packages.sqlalchemy-adapter.dist
  • python314Packages.types-paramiko
  • python314Packages.types-paramiko.dist
  • skypilot
  • skypilot.dist

aarch64-linux

✅ 10 packages built:
  • python313Packages.sqlalchemy-adapter
  • python313Packages.sqlalchemy-adapter.dist
  • python313Packages.types-paramiko
  • python313Packages.types-paramiko.dist
  • python314Packages.sqlalchemy-adapter
  • python314Packages.sqlalchemy-adapter.dist
  • python314Packages.types-paramiko
  • python314Packages.types-paramiko.dist
  • skypilot
  • skypilot.dist

x86_64-darwin

✅ 10 packages built:
  • python313Packages.sqlalchemy-adapter
  • python313Packages.sqlalchemy-adapter.dist
  • python313Packages.types-paramiko
  • python313Packages.types-paramiko.dist
  • python314Packages.sqlalchemy-adapter
  • python314Packages.sqlalchemy-adapter.dist
  • python314Packages.types-paramiko
  • python314Packages.types-paramiko.dist
  • skypilot
  • skypilot.dist

aarch64-darwin

✅ 10 packages built:
  • python313Packages.sqlalchemy-adapter
  • python313Packages.sqlalchemy-adapter.dist
  • python313Packages.types-paramiko
  • python313Packages.types-paramiko.dist
  • python314Packages.sqlalchemy-adapter
  • python314Packages.sqlalchemy-adapter.dist
  • python314Packages.types-paramiko
  • python314Packages.types-paramiko.dist
  • skypilot
  • skypilot.dist

@GaetanLepage GaetanLepage added this pull request to the merge queue Apr 20, 2026
Merged via the queue into NixOS:master with commit 09c3d7c Apr 20, 2026
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@natsukium natsukium Awaiting requested review from natsukium

@seanrmurphy seanrmurphy Awaiting requested review from seanrmurphy

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daspk04 @GaetanLepage