Skip to content

openconnect: fix missing iconv on Darwin#511586

Merged
drupol merged 1 commit intoNixOS:staging-nextfrom
sarahec:fix-openconnect
Apr 20, 2026
Merged

openconnect: fix missing iconv on Darwin#511586
drupol merged 1 commit intoNixOS:staging-nextfrom
sarahec:fix-openconnect

Conversation

@sarahec
Copy link
Copy Markdown
Contributor

@sarahec sarahec commented Apr 19, 2026

Hydra: 326248787

Build fails on Darwin with "__iconv undefined".
Set env.am_cv_func_iconv_works = "yes" so it uses the existing library.

Tracking: #511329

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@sarahec sarahec changed the base branch from master to staging-next April 19, 2026 22:58
@nixpkgs-ci nixpkgs-ci Bot closed this Apr 19, 2026
@nixpkgs-ci nixpkgs-ci Bot reopened this Apr 19, 2026
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Apr 19, 2026
@booxter
Copy link
Copy Markdown
Contributor

booxter commented Apr 20, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 511586 --package openconnect
Commit: 00bd3ffc1a00d5e476f9a27c584ca50aac1783af


x86_64-linux

✅ 2 packages built:
  • openconnect
  • openconnect.dev (openconnect.dev.dev)

aarch64-linux

✅ 2 packages built:
  • openconnect
  • openconnect.dev (openconnect.dev.dev)

aarch64-darwin

✅ 2 packages built:
  • openconnect
  • openconnect.dev (openconnect.dev.dev)

@ofborg ofborg Bot added the 6.topic: darwin Running or building packages on Darwin label Apr 20, 2026
@drupol drupol added this pull request to the merge queue Apr 20, 2026
Merged via the queue into NixOS:staging-next with commit b1d3718 Apr 20, 2026
44 of 48 checks passed
@sarahec sarahec deleted the fix-openconnect branch April 20, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants