Open
Conversation
1412d08 to
2d4fc61
Compare
2d4fc61 to
29d0237
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
I added some core abstractions on top of the general configuration options!
They are:
A structured secrets file attribute for the various methods of storing secrets with Kratos -- as a runtime overlay to avoid the nix store for these sensitive bits
A eensie URL abstraction to avoid public, admin, etc.
The common createLocally abstraction for the database, which makes it easy to keep it contained.
Built on platform:
Tested, as applicable:
passthru.tests.Ran
nixpkgs-reviewon this PR. See nixpkgs-review usage.Tested basic functionality of all binary files, usually in
./result/bin/.Nixpkgs Release Notes
NixOS Release Notes
Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.