Skip to content

nixos/stargazer: remove absolute path literals#513214

Merged
Scrumplex merged 1 commit into
NixOS:masterfrom
ameertaweel:stargazer-remove-absolute-path-literals
Apr 26, 2026
Merged

nixos/stargazer: remove absolute path literals#513214
Scrumplex merged 1 commit into
NixOS:masterfrom
ameertaweel:stargazer-remove-absolute-path-literals

Conversation

@ameertaweel
Copy link
Copy Markdown
Contributor

@ameertaweel ameertaweel commented Apr 24, 2026

Absolute path literals are not portable.
Nix complains about the changed lines if the option lint-absolute-path-literals is set to warn.

lint-absolute-path-literals Option Documentation:
https://nix.dev/manual/nix/2.34/command-ref/conf-file.html#conf-lint-absolute-path-literals

I'm making several PRs to Nixpkgs to resolve all instances of this issue.
#511569 was merged before I make this PR.

This PR is part of a batch of 5 PRs:

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@ameertaweel ameertaweel requested a review from nikstur April 24, 2026 22:47
@nixpkgs-ci nixpkgs-ci Bot requested a review from gaykitty April 24, 2026 22:53
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 24, 2026
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/6804

Copy link
Copy Markdown
Contributor

@gaykitty gaykitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 25, 2026
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/remove-all-absolute-path-literals-from-nixpkgs/77245/1

@Scrumplex Scrumplex added this pull request to the merge queue Apr 26, 2026
Merged via the queue into NixOS:master with commit cad20b9 Apr 26, 2026
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants