Skip to content

nim: deprecate and move os and cpu to stdenv.targetPlatform.nim#513302

Merged
alyssais merged 1 commit into
NixOS:masterfrom
Eveeifyeve:nim-os-cpu-move-stdenv
May 6, 2026
Merged

nim: deprecate and move os and cpu to stdenv.targetPlatform.nim#513302
alyssais merged 1 commit into
NixOS:masterfrom
Eveeifyeve:nim-os-cpu-move-stdenv

Conversation

@Eveeifyeve
Copy link
Copy Markdown
Member

@Eveeifyeve Eveeifyeve commented Apr 25, 2026 •
edited
Loading

This change makes it more accesssable to using nim cpu and os without
referencing nim.

Derived from #496960 to help with merge/reviewing process.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@Eveeifyeve Eveeifyeve mentioned this pull request Apr 25, 2026
Open
13 tasks
@nixpkgs-ci nixpkgs-ci Bot requested review from a team, alyssais, daylinmorgan and eclairevoyant April 25, 2026 08:20
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: lib The Nixpkgs function library labels Apr 25, 2026
@Eveeifyeve Eveeifyeve mentioned this pull request Apr 25, 2026
Open
17 tasks
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 4, 2026
alyssais
alyssais reviewed May 4, 2026
View reviewed changes
Comment thread pkgs/by-name/ni/nim-unwrapped-2_2/package.nix
@Eveeifyeve Eveeifyeve force-pushed the nim-os-cpu-move-stdenv branch 4 times, most recently from ca13a6c to a1ea129 Compare May 6, 2026 12:18
@Eveeifyeve
nim: deprecate and move os and cpu to stdenv.targetPlatform.nim
a8f0a99 
This change makes it more accesssable to using nim cpu and os without
referencing nim.
@Eveeifyeve Eveeifyeve force-pushed the nim-os-cpu-move-stdenv branch from a1ea129 to a8f0a99 Compare May 6, 2026 12:29
@alyssais alyssais added this pull request to the merge queue May 6, 2026
Merged via the queue into NixOS:master with commit a5974a5 May 6, 2026
29 checks passed
@Eveeifyeve Eveeifyeve deleted the nim-os-cpu-move-stdenv branch May 7, 2026 01:16
@trofi
Copy link
Copy Markdown
Contributor

trofi commented May 7, 2026

stdenv.hostPlatform.cpu seems to be incorrect and breaks nim.nim.nimTarget eval. Proposed the possible fix as:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais alyssais left review comments

@eclairevoyant eclairevoyant Awaiting requested review from eclairevoyant

+1 more reviewer

@daylinmorgan daylinmorgan daylinmorgan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

Nixpkgs Lib
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Eveeifyeve @trofi @alyssais @daylinmorgan