Skip to content

nixos/forgejo-runner: init module#518320

Closed
caniko wants to merge 2 commits into
NixOS:masterfrom
caniko:forgejo-runner-module
Closed

nixos/forgejo-runner: init module#518320
caniko wants to merge 2 commits into
NixOS:masterfrom
caniko:forgejo-runner-module

Conversation

@caniko

@caniko caniko commented May 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds a dedicated NixOS module for Forgejo Runner using declarative server.connections configuration. This avoids the deprecated imperative register flow and supports credential-backed tokens through systemd LoadCredential.

Review notes:

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 9, 2026
@caniko

caniko commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 518320
Commit: 0df95736a5ac0f827ad9daab56031cd3766c6bb1 (subsequent changes)
Merge: bf55716c6e845852648d1e81a732e8e9ccfc5c73

Logs: https://github.com/caniko/nixpkgs-review-gha/actions/runs/25596696212

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@caniko

caniko commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 518320
Commit: e1d99f445e8ba6b0897c7dce66566b2416628756 (subsequent changes)
Merge: 31897285c1228cfc2286d83bf37adee633e82021

Logs: https://github.com/caniko/nixpkgs-review-gha/actions/runs/25597185446

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@caniko
caniko marked this pull request as ready for review May 9, 2026 09:11
@nixpkgs-ci nixpkgs-ci Bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label May 9, 2026
@emilylange

emilylange commented May 12, 2026

Copy link
Copy Markdown
Member

Conflicts with #496325.

Closing as duplicate of #496325.

@emilylange emilylange closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@caniko @emilylange