Skip to content

chore: remove unused file#521074

Open
Malix-Labs wants to merge 1 commit into
NixOS:masterfrom
Malix-Labs:remove-unused-file
Open

chore: remove unused file#521074
Malix-Labs wants to merge 1 commit into
NixOS:masterfrom
Malix-Labs:remove-unused-file

Conversation

@Malix-Labs
Copy link
Copy Markdown
Contributor

@Malix-Labs Malix-Labs commented May 16, 2026

This file is unused and not displayed, since there are files in .github/ISSUE_TEMPLATE

Its content can be used if an equivalent form is created in .github/ISSUE_TEMPLATE AND .github/ISSUE_TEMPLATE/config.yml > blank_issues_enabled: false

But right now, there is no .github/ISSUE_TEMPLATE/config.yml file, and so blank_issues_enabled defaults to true

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested a review from SigmaSquadron May 16, 2026 19:57
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs labels May 16, 2026
Copy link
Copy Markdown
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true. This file is used when someone decides to open a blank issue. You have misinterpreted the documentation you linked.

Additionally, please review our commit conventions. We do not use the feat/chore nomenclature in Nixpkgs.

@Malix-Labs
Copy link
Copy Markdown
Contributor Author

Malix-Labs commented May 17, 2026

Not true. This file is used when someone decides to open a blank issue. You have misinterpreted the documentation you linked

I tested it beforehand, and this is not the case on my end :

  • image
  • image

Please test on your end

Additionally, please review our commit conventions. We do not use the feat/chore nomenclature in Nixpkgs

I know. I have no idea what to call it otherwise (except "config", "github", ... ?), feel free to propose what I should call it instead

And apparently I'm not alone to not know : https://github.com/NixOS/nixpkgs/commits/master/.github/ISSUE_TEMPLATE.md

@Malix-Labs
Copy link
Copy Markdown
Contributor Author

^ @SigmaSquadron please review #521074 (comment)

@Malix-Labs
Copy link
Copy Markdown
Contributor Author

I made some more tests with some different configuration, and I couldn't make the blank template have a default template like what is suggested in the doc.

This PR should be reopened

@SigmaSquadron
Copy link
Copy Markdown
Contributor

Reopened why, exactly? All you've proven here is that GitHub is inconsistently applying their own documentation to the issue creation forms. Once they fix this bug, (and this is a bug as their own documentation describes a different behaviour) we would be left with no blank issue template if this is merged.

I don't see a benefit to removing a tiny file that may be useful for us in the future when GitHub fixes this bug. Honestly, there are far more pressing matters to attend to in Nixpkgs than trying to flip-flop between whatever GitHub is doing at any given moment.

@Malix-Labs
Copy link
Copy Markdown
Contributor Author

Malix-Labs commented May 17, 2026

I will ask GitHub if it's a bug and should be resolved or if it's a deprecated feature (since it seems to be according to the "legacy" wording)

@Malix-Labs
Copy link
Copy Markdown
Contributor Author

See #44311

@Malix-Labs
Copy link
Copy Markdown
Contributor Author

Malix-Labs commented May 21, 2026

Confirmed as deprecated : github/docs#44312 (comment)

Please reopen this PR

@SigmaSquadron SigmaSquadron reopened this May 22, 2026
@Malix-Labs Malix-Labs requested a review from SigmaSquadron May 22, 2026 09:52
@SigmaSquadron
Copy link
Copy Markdown
Contributor

There is no need to request my review before you address my previous reviews. This still does not follow our commit conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants