Skip to content

python3Packages.pytask: 0.5.8 -> 0.6.0#521576

Merged
vcunat merged 1 commit into
NixOS:masterfrom
MiniHarinn:fix/python314Packages.pytask
May 20, 2026
Merged

python3Packages.pytask: 0.5.8 -> 0.6.0#521576
vcunat merged 1 commit into
NixOS:masterfrom
MiniHarinn:fix/python314Packages.pytask

Conversation

@MiniHarinn
Copy link
Copy Markdown
Contributor

@MiniHarinn MiniHarinn commented May 18, 2026

Release: https://github.com/pytask-dev/pytask/releases/tag/v0.6.0
Diff: pytask-dev/pytask@v0.5.8...v0.6.0
ZHF: #516381 (Part of)

Hydra Failure (Click the banner to go to Hydra build report):

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@MiniHarinn MiniHarinn added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 18, 2026
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels May 18, 2026
@MiniHarinn MiniHarinn changed the title python3Packages.pytask: backport database_url config fix and skip pygraphviz mock tests python3Packages.pytask: 0.5.8 -> 0.6.0 May 18, 2026
@MiniHarinn MiniHarinn force-pushed the fix/python314Packages.pytask branch from c55b2cf to 183a9fb Compare May 18, 2026 13:55
@nixpkgs-ci nixpkgs-ci Bot added the 8.has: package (update) This PR updates a package to a newer version label May 18, 2026
@MiniHarinn

This comment was marked as outdated.

@MiniHarinn MiniHarinn marked this pull request as ready for review May 18, 2026 14:07
@nixpkgs-ci nixpkgs-ci Bot requested a review from erooke May 18, 2026 14:49
Comment on lines 52 to 54
tomli-w
universal-pathlib
];
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tomli-w
universal-pathlib
];
universal-pathlib
]
++ msgspec.optional-dependencies.toml;

cloudpickle
git
nbmake
networkx
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
networkx

pytest-xdist
pytestCheckHook
syrupy
];
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
];
]
++ lib.concatAttrValues optional-dependencies;

networkx
pexpect
pytest-xdist
pytestCheckHook
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pytestCheckHook
pytest-xdist
pytestCheckHook

Feel free to keep pytest-xdist as it speeds up the tests (8 vs. 40 seconds on my machine).

Comment thread pkgs/development/python-modules/pytask/default.nix
Copy link
Copy Markdown
Contributor

@erooke erooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me. I concur with the changes @thunze proposed.

Comment on lines 82 to 83
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has very little to do with the PR but this test now passes due to: pytask-dev/pytask#713

@MiniHarinn MiniHarinn force-pushed the fix/python314Packages.pytask branch from 183a9fb to 1085cd5 Compare May 19, 2026 05:09
@MiniHarinn
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 521576
Commit: 1085cd5f2f5475567980ebd4c69f5135423a934e (subsequent changes)
Merge: 2a1e865bc69550d71b9ed954fbdb56b92fa426ae

Logs: https://github.com/MiniHarinn/nixpkgs-review-gha/actions/runs/26077576674


x86_64-linux

✅ 4 packages built:
  • python313Packages.pytask
  • python313Packages.pytask.dist
  • python314Packages.pytask
  • python314Packages.pytask.dist

aarch64-linux

✅ 4 packages built:
  • python313Packages.pytask
  • python313Packages.pytask.dist
  • python314Packages.pytask
  • python314Packages.pytask.dist

x86_64-darwin (sandbox = relaxed)

✅ 4 packages built:
  • python313Packages.pytask
  • python313Packages.pytask.dist
  • python314Packages.pytask
  • python314Packages.pytask.dist

aarch64-darwin (sandbox = relaxed)

✅ 4 packages built:
  • python313Packages.pytask
  • python313Packages.pytask.dist
  • python314Packages.pytask
  • python314Packages.pytask.dist

Copy link
Copy Markdown
Member

@thunze thunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Verified that all of python3{13,14}Packages.pytask build on x86_64-linux
  • Verified that the usage example works for all of python3{13,14}Packages.pytask on x86_64-linux

Thanks!

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 19, 2026
Copy link
Copy Markdown
Contributor

@erooke erooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 20, 2026
@vcunat vcunat added this pull request to the merge queue May 20, 2026
Merged via the queue into NixOS:master with commit cd3f235 May 20, 2026
33 of 36 checks passed
@MiniHarinn MiniHarinn deleted the fix/python314Packages.pytask branch May 23, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants