scaleway-cli: 2.54.0 -> 2.56.0#521971
Conversation
|
|
Builds, runs, LGTM |
|
maxbrunet
left a comment
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
woile
left a comment
There was a problem hiding this comment.
Tested on x86_64 and works well ✔️
I urge merging this PR as current unstable is broken, it fails with:
--- FAIL: TestMarshal (0.00s)
--- FAIL: TestMarshal/structWithMapsInSection (0.00s)
marshal_test.go:155:
Error Trace: /build/source/core/human/marshal_test.go:91
Error: Not equal:
expected: "String This is a string\nInt 42\nBool true\nStrings>
actual : "String This is a string\nInt 42\nBool true\nStrings>
Diff:
--- Expected
+++ Actual
@@ -5,3 +5,3 @@
Strings.1 s2
-Time 35 years ago
+Time 36 years ago
Struct.String -
Test: TestMarshal/structWithMapsInSection
FAIL
FAIL github.com/scaleway/scaleway-cli/v2/core/human 0.003s
FAIL
Nothing wrong with this PR, but it's worth noting that this does not fix the root cause of the build failure. See #527216. |
Isn't the implication with that that the build failure only happens on the current version and that it's fixed in the version this PR updates to? |
No. It's a nondeterministic test. It will start failing again roughly one year from now. This PR temporarily fixes it because the version bump brings in scaleway/scaleway-cli#5567, which simply kicks the can down the road. |
|
superseded by #511751 |
Diff: scaleway/scaleway-cli@v2.54.0...v2.56.0
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.