Skip to content

scaleway-cli: 2.54.0 -> 2.56.0#521971

Closed
techknowlogick wants to merge 1 commit into
NixOS:masterfrom
techknowlogick:scw-2560
Closed

scaleway-cli: 2.54.0 -> 2.56.0#521971
techknowlogick wants to merge 1 commit into
NixOS:masterfrom
techknowlogick:scw-2560

Conversation

@techknowlogick

Copy link
Copy Markdown
Member

Diff: scaleway/scaleway-cli@v2.54.0...v2.56.0

Things done

@nixpkgs-ci nixpkgs-ci Bot requested review from NickHu and kashw2 May 19, 2026 15:03
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 19, 2026
@GiggleSquid

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 521971
Commit: 781da64bb43f92d9fc5b5c22415bd61611927509


x86_64-linux

✅ 1 package built:
  • scaleway-cli

@GiggleSquid

Copy link
Copy Markdown
Contributor

Builds, runs, LGTM

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 19, 2026
@maxbrunet

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 521971
Commit: 781da64bb43f92d9fc5b5c22415bd61611927509 (subsequent changes)
Merge: e577134c31cf4b3fad2bbd7cefb8471c84d28d20

Logs: https://github.com/maxbrunet/nixpkgs-review-gha/actions/runs/26337263629


x86_64-linux

✅ 1 package built:
  • scaleway-cli

aarch64-linux

✅ 1 package built:
  • scaleway-cli

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • scaleway-cli

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • scaleway-cli

@maxbrunet maxbrunet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 23, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels May 24, 2026

@woile woile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64 and works well ✔️

I urge merging this PR as current unstable is broken, it fails with:

--- FAIL: TestMarshal (0.00s)
    --- FAIL: TestMarshal/structWithMapsInSection (0.00s)
        marshal_test.go:155:
                Error Trace:    /build/source/core/human/marshal_test.go:91
                Error:          Not equal:
                                expected: "String              This is a string\nInt                 42\nBool                true\nStrings>
                                actual  : "String              This is a string\nInt                 42\nBool                true\nStrings>

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -5,3 +5,3 @@
                                 Strings.1           s2
                                -Time                35 years ago
                                +Time                36 years ago
                                 Struct.String       -
                Test:           TestMarshal/structWithMapsInSection
FAIL
FAIL    github.com/scaleway/scaleway-cli/v2/core/human  0.003s
FAIL

@BhasherBEL BhasherBEL added the backport release-26.05 Backport PR automatically label May 28, 2026
@samestep

samestep commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

I urge merging this PR as current unstable is broken

Nothing wrong with this PR, but it's worth noting that this does not fix the root cause of the build failure. See #527216.

@kashw2

kashw2 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Nothing wrong with this PR, but it's worth noting that this does not fix the root cause of the build failure. See #527216.

Isn't the implication with that that the build failure only happens on the current version and that it's fixed in the version this PR updates to?

@samestep

samestep commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Isn't the implication with that that the build failure only happens on the current version and that it's fixed in the version this PR updates to?

No. It's a nondeterministic test. It will start failing again roughly one year from now. This PR temporarily fixes it because the version bump brings in scaleway/scaleway-cli#5567, which simply kicks the can down the road.

@kashw2

kashw2 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

superseded by #511751

@kashw2 kashw2 closed this Jun 3, 2026
@techknowlogick techknowlogick deleted the scw-2560 branch June 3, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-26.05 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants