Skip to content

gemini-cli: add warning - #522364

Open
Djabx wants to merge 1 commit into
NixOS:masterfrom
Djabx:gemini-cli-warning
Open

gemini-cli: add warning#522364
Djabx wants to merge 1 commit into
NixOS:masterfrom
Djabx:gemini-cli-warning

Conversation

@Djabx

@Djabx Djabx commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Things done

@Djabx Djabx mentioned this pull request May 20, 2026
Open
14 tasks
@Djabx
Djabx force-pushed the gemini-cli-warning branch 3 times, most recently from e7654b1 to 4e12afb Compare May 20, 2026 21:23
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 20, 2026
@Djabx

Djabx commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 522364
Commit: 4e12afb3b84d4f943df8e9a42672d3ef9fd12ced

@Djabx
Djabx marked this pull request as ready for review May 20, 2026 22:23
@Djabx Djabx self-assigned this May 22, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 23, 2026
Sigmanificient
Sigmanificient reviewed May 23, 2026
View reviewed changes
Comment thread pkgs/by-name/ge/gemini-cli/package.nix Outdated
homepage = "https://github.com/google-gemini/gemini-cli";
license = lib.licenses.asl20;
sourceProvenance = with lib.sourceTypes; [ fromSource ];
knownVulnerabilities = [ "gemini-cli will be deprecated and removed in a future release." ];

@Sigmanificient Sigmanificient May 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoudn't we use meta.problems for this?

@Djabx Djabx May 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any "clear" guidelines ? I did not find any.

@Djabx Djabx May 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I can't find anything about meta.problems here: https://nixos.org/manual/nixpkgs/stable/#sec-standard-meta-attributes

@taranarmo taranarmo May 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try unstable version since you're targeting master

@Djabx Djabx May 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

I never noticed there was 2 version of the doc.

I've made the modification (rebased).

@taranarmo taranarmo May 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sigmanificient do you have a following hint?

@Sigmanificient Sigmanificient May 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta.problems is quite new, i think we might be in the first to use it :D

@MattSturgeon MattSturgeon Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In hindsight, I think it would've been fine to land the knownVulnerabilities warning, with a FIXME comment about switching to meta.problems. I don't think using meta.problems needed to delay this PR by a month 😁

Hopefully the solution is close enough that there's no reason to do that now, though.

@Sigmanificient Sigmanificient Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MattSturgeon well the initial pr was opened a day after my issue was raised, i thought this would have be sorted quickly, but time went by 😓

@taranarmo taranarmo Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I stopped following Google's plans on maintaining gemini-cli vs antigravity-cli, it seems like the former won't be deprecated for a while but kept for corporate users, though e.g. home-manager renamed the gemini-cli module to antigravity-cli already nix-community/home-manager#9365

@Djabx
Djabx force-pushed the gemini-cli-warning branch 2 times, most recently from 9b3708c to 9e4d592 Compare May 24, 2026 17:09
@Sigmanificient Sigmanificient mentioned this pull request May 24, 2026
Closed
@caverav caverav mentioned this pull request May 25, 2026
Closed
14 tasks
@Djabx
Djabx force-pushed the gemini-cli-warning branch 3 times, most recently from cb784d1 to 448760a Compare May 25, 2026 07:35
@taranarmo

taranarmo commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

There's a PR fixing CI issue, you may want to wait until it's merged

@Djabx
Djabx force-pushed the gemini-cli-warning branch from 448760a to bc9319e Compare May 25, 2026 08:57
@gepbird

gepbird commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Can you rebase? It should fix CI.

@Djabx
Djabx force-pushed the gemini-cli-warning branch from bc9319e to 723d0f9 Compare July 1, 2026 21:57
@Djabx

Djabx commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Can you rebase? It should fix CI.

Done

@gepbird gepbird closed this Jul 1, 2026
@gepbird gepbird reopened this Jul 1, 2026
@gepbird

gepbird commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Hmm, it still fails:

       >        error: evaluation aborted with the following error message: 'gemini-cli is disallowed from being used within Nixpkgs, because it has certain meta.problems whose kinds are disallowed: {
       >          removal = {
       >            kind = "removal";
       >            message = "gemini-cli will be deprecated and removed in a future release.";
       >          };
       >        }'

You've correctly updated the base branch. I've seen this kind of CI failure get fixed after #537051, but it's still stuck. Most likely we will need #537051 as a vscode extension depends on this package.

@MattSturgeon

MattSturgeon commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Now #537051 is merged, you'll need to inspect the stack trace, to see which package is depending on gemini-cli.

Once you've identified the the reverse dependency, you'll need to add a meta.problems.removal to it, too.

I don't think there's a consensus yet on how to phrase those "a transitive dependency of mine is marked for removal" problems, though.

@MattSturgeon MattSturgeon mentioned this pull request Jul 2, 2026
Open
13 tasks
@Djabx
Djabx force-pushed the gemini-cli-warning branch from 723d0f9 to 2d442cd Compare July 3, 2026 16:59
@nixpkgs-ci nixpkgs-ci Bot added the 6.topic: vscode A free and versatile code editor that supports almost every major programming language. label Jul 3, 2026
@Djabx

Djabx commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

It's all green !

But as @taranarmo say:

it seems like the former won't be deprecated for a while but kept for corporate users

Should we merge anyway ?

@taranarmo

taranarmo commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Maybe the message should be changed to some official statement by Google, it's obviously going from the large scene (I mentioned that home-manager already merged module rename to antigravity). So it seems like kind of deprecation after all at least for non-corporate users.

@Djabx

Djabx commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Something like:
"Unpaid tier and Google One users: Gemini CLI will be replaced by Antigravity CLI "

(see https://geminicli.com/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattSturgeon MattSturgeon MattSturgeon left review comments
@Sigmanificient Sigmanificient Sigmanificient left review comments
@caverav caverav Awaiting requested review from caverav
@4evy 4evy Awaiting requested review from 4evy
@pedrobrantes pedrobrantes Awaiting requested review from pedrobrantes
@xiaoxiangmoe xiaoxiangmoe Awaiting requested review from xiaoxiangmoe
+1 more reviewer
@taranarmo taranarmo taranarmo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Djabx Djabx

Labels

6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Djabx @taranarmo @gepbird @MattSturgeon @Sigmanificient