Skip to content

python313Packages.fs: mark broken#541148

Merged
dotlambda merged 5 commits into
NixOS:masterfrom
dotlambda:python3Packages.fs
Jul 12, 2026
Merged

python313Packages.fs: mark broken#541148
dotlambda merged 5 commits into
NixOS:masterfrom
dotlambda:python3Packages.fs

Conversation

@dotlambda

@dotlambda dotlambda commented Jul 12, 2026

Copy link
Copy Markdown
Member

This reverts commit 6c81b30 because versioned attributes are not allowed in dependencies. This lead to two versions of setuptools in bentoml's closure.
It doesn't suffice to use setuptools_80 in build-system because fs imports pkg_resources.
Alternatively we can apply patches mentioned in PyFilesystem/pyfilesystem2#590 (comment)

Things done

This reverts commit 6c81b30 because
versioned attributes are not allowed in `dependencies`.
This lead to two versions of setuptools in bentoml's closure.
@dotlambda dotlambda requested a review from mweinelt July 12, 2026 18:51
@dotlambda dotlambda force-pushed the python3Packages.fs branch from 067b930 to 358498b Compare July 12, 2026 18:55
@dotlambda dotlambda changed the title python3Packages.fs: mark broken python313Packages.fs: mark broken Jul 12, 2026
It doesn't suffice to use setuptools_80 in `build-system` because fs
imports pkg_resources.
@dotlambda dotlambda force-pushed the python3Packages.fs branch from 358498b to 5c54aea Compare July 12, 2026 19:05
@nixpkgs-ci nixpkgs-ci Bot requested a review from danc86 July 12, 2026 19:11
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Jul 12, 2026
@dotlambda

Copy link
Copy Markdown
Member Author

@happysalada @natsukium Bentoml needs to be updated and fs (and others) removed from its list of dependencies. Please also note the many issues nixpkgs-security-tracker opened.

@dotlambda

Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 541148
Commit: 0897fed1ad28b2196bebd97873b59e162d138fc7


x86_64-linux

❌ 4 packages failed to build:
  • fontbakery (python314Packages.fontbakery)
  • python313Packages.fontbakery
  • python313Packages.notobuilder
  • python314Packages.notobuilder
✅ 19 packages built:
  • jetbrains-mono
  • python313Packages.babelfont
  • python313Packages.collidoscope
  • python313Packages.fontfeatures
  • python313Packages.foundrytools
  • python313Packages.gftools
  • python313Packages.statmake
  • python313Packages.ufo-extractor
  • python313Packages.ufolint
  • python313Packages.ufomerge
  • python314Packages.babelfont
  • python314Packages.collidoscope
  • python314Packages.fontfeatures
  • python314Packages.foundrytools
  • python314Packages.gftools
  • python314Packages.statmake
  • python314Packages.ufo-extractor
  • ufolint (python314Packages.ufolint)
  • python314Packages.ufomerge

@happysalada

Copy link
Copy Markdown
Contributor

Source looks good
Are the review failures still there on master , or are those linked to the changes ?

@dotlambda dotlambda added this pull request to the merge queue Jul 12, 2026
@dotlambda

Copy link
Copy Markdown
Member Author

Are the review failures still there on master , or are those linked to the changes ?

How about you put in some work yourself? Instead I have to clean up after your unmaintained packages.

Merged via the queue into NixOS:master with commit f1ac8de Jul 12, 2026
25 checks passed
@dotlambda dotlambda deleted the python3Packages.fs branch July 12, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants