python313Packages.fs: mark broken#541148
Merged
Merged
Conversation
This reverts commit 6c81b30 because versioned attributes are not allowed in `dependencies`. This lead to two versions of setuptools in bentoml's closure.
067b930 to
358498b
Compare
It doesn't suffice to use setuptools_80 in `build-system` because fs imports pkg_resources.
358498b to
5c54aea
Compare
Member
Author
|
@happysalada @natsukium Bentoml needs to be updated and fs (and others) removed from its list of dependencies. Please also note the many issues nixpkgs-security-tracker opened. |
Member
Author
|
Contributor
|
Source looks good |
Member
Author
How about you put in some work yourself? Instead I have to clean up after your unmaintained packages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6c81b30 because versioned attributes are not allowed in
dependencies. This lead to two versions of setuptools in bentoml's closure.It doesn't suffice to use setuptools_80 in
build-systembecause fs imports pkg_resources.Alternatively we can apply patches mentioned in PyFilesystem/pyfilesystem2#590 (comment)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.