pymol: fix AttributeError in set command#543802
Open
vldmrtlk wants to merge 1 commit into
Open
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
natsukium
reviewed
Jul 20, 2026
natsukium
left a comment
natsukium
left a comment
Member
There was a problem hiding this comment.
LGTM overall, just left a minor nit.
| hash = "sha256-dcYRzUhiaGlR3CjQ0BktA5L+8lFyVdw0+hIz3Li7gDQ="; | ||
| }) | ||
| # Fixes `set` command with int/float arguments, i.e. `set transparency, 0.5` | ||
| (fetchpatch { |
Member
There was a problem hiding this comment.
Please use fetchpatch2 here.
Lines 619 to 621 in 09f6928
Author
There was a problem hiding this comment.
changed to fetchpatch2 only for the patch i've added, there are 3 other patches applied with fetchpatch though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue
calls of
setwith float or integer arguments (i.e.set transparency, 0.3) lead to AttributeError due to missinghas_keyattribute inShortcutclass. It seems that 6d9211a added patches that lead to refactoring ofShortcutclass while stale call ofhas_keyinsettings.pywas left out.changes
added upstream patch schrodinger/pymol-open-source@7124684 which removes the stale call.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.