fusee-nano: fix version scheme#543810
Merged
Merged
Conversation
notklea
marked this pull request as ready for review
July 20, 2026 10:55
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
MiniHarinn
reviewed
Jul 20, 2026
| stdenv.mkDerivation { | ||
| pname = "fusee-nano"; | ||
| version = "unstable-2023-05-17"; | ||
| version = "0.5.3-unstable-2023-05-17"; |
Member
There was a problem hiding this comment.
Suggested change
| version = "0.5.3-unstable-2023-05-17"; | |
| version = "0.5.3-unstable-2023-05-18"; |
Member
There was a problem hiding this comment.
committed on May 18, 2023
Or is it because of my tz? Can you help me verify?
Member
There was a problem hiding this comment.
Yes, this is a timezone difference. I don't know if there's a convention for this but it's the 17th in my local timezone, the upstream commit's local timezone, and UTC.
Member
There was a problem hiding this comment.
Thanks, I guess we are fine with 17th then :)
Contributor
Author
There was a problem hiding this comment.
I wrote this cursed piece of code, in case you want to test it for other repos:
(
git clone https://github.com/DavidBuchanan314/fusee-nano
cd fusee-nano
date -u -d"@$(git rev-list -1 --no-commit-header --format=%ct 2979d34f470d02f34594d8d59be1f5c7bf4bf73f)" "+%F" >&6
cd ..
rm -rf fusee-nano
) 6>&1 1>/dev/null 2>/dev/null
The important function is mostly git rev-list -1 --no-commit-header --format=%ct $commit_reference, and then using date -u -d@$timestamp +%F.
leo60228
approved these changes
Jul 20, 2026
MiniHarinn
approved these changes
Jul 20, 2026
nixpkgs-ci
Bot
added
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the version scheme per #541820.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.