androidenv: generate metadata correctly for abi variants#543811
Open
RohanHart wants to merge 1 commit into
Open
androidenv: generate metadata correctly for abi variants#543811RohanHart wants to merge 1 commit into
RohanHart wants to merge 1 commit into
Conversation
Because a single abi such as x86_64 can have multiple variants which are not distinguished by checking only the first tag. Due to package ordering in the source metadata that prevented using non-16kb memory page images for at least Android API 36.1. Also sorts the tags alphanumericly to avoid cases where Google are not consistent.
nixpkgs-ci
Bot
added
10.rebuild-linux: 11-100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because a single abi such as x86_64 can have multiple variants which are not distinguished by checking only the first tag. Due to package ordering in the source metadata that prevented using non-16kb memory page images for at least Android API 36.1.
Also sorts the tags alphanumericly to avoid cases where Google are not consistent.
This does result in additional
systemImageTypessuch asgoogle_apis_playstore-page_size_16kbhowever I don't see where these are documented outside the repo.json.For some reason when creating or editing a virtual device the system image shows as the "Pre-Release 16KB Page Size" for 36.1 even though it is displayed correctly in the SDK Manager and can be confirmed as a 4kb by running
repo.jsonhas been regenerated based on6ff5d4adb863as that was the last commit before the tagging changes appear to have been an issue.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.