docker-machine-xhyve: enable and fix lib9p file sharing#75432
Merged
marsam merged 4 commits intoNixOS:masterfrom Jan 15, 2020
mroi:patch-xhyve
Merged
docker-machine-xhyve: enable and fix lib9p file sharing#75432marsam merged 4 commits intoNixOS:masterfrom mroi:patch-xhyve
marsam merged 4 commits intoNixOS:masterfrom
mroi:patch-xhyve
Conversation
The zchee repository now redirects to machine-drivers.
mroi
changed the title
ofborg
Bot
added
10.rebuild-darwin: 1-10
marsam
reviewed
Dec 12, 2019
marsam
reviewed
Dec 12, 2019
remove explicit dependencies, upstream vendorizes them properly
The lib9p library for host-guest file sharing in xhyve needs to be built separately.
File modes are not properly translated from L9P to host values. Instead, they are assumed to be identical, which is wrong on macOS. machine-drivers/docker-machine-driver-xhyve#225
Contributor
|
Thank you @mroi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to run a docker-machine VM based on the xyhve hypervisor (which uses the built-in hypervisor in macOS). However, the currently packaged version did not support file system sharing, so I enabled
lib9p. I then figured out that it is currently broken and my upstream pull request is pending.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @periklis