Skip to content

Commit a336400

Browse files
committed
Range and CooperativeSticky are not compatible
We're gettingt this error: All partition.assignment.strategy (range,cooperative-sticky) assignors must have the same protocol type, online migration between assignors with different protocol types is not supported Some minimal reading of rdkafka made us believe range is EAGER and cooperative-sticky is .. well .. COOPERATIVE, which are different protocol types. This means we can't use both at the same time and in practice, means we need downtime on workers when deploying this change. Not terrible tbh.
1 parent 54ef5f6 commit a336400

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

nri-kafka/src/Kafka/Worker/Internal.hs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,8 +270,9 @@ createConsumer
270270
++ Consumer.compression Consumer.Snappy
271271
++ Consumer.extraProps
272272
( Dict.fromList
273-
[("max.poll.interval.ms", Text.fromInt (Settings.unMaxPollIntervalMs maxPollIntervalMs))
274-
, ("partition.assignment.strategy", "range,cooperative-sticky")]
273+
[ ("max.poll.interval.ms", Text.fromInt (Settings.unMaxPollIntervalMs maxPollIntervalMs)),
274+
("partition.assignment.strategy", "cooperative-sticky")
275+
]
275276
)
276277
++ case maybeStatsCallback of
277278
Nothing -> Prelude.mempty

0 commit comments

Comments
 (0)