style: hygiene pass on async seam changes

Behavior-preserving cleanups from a code-hygiene review of the PR + AsyncState
refactor:
- async_view.rs: drop a needless Option<String> clone in the error arm.
- notification_popover.rs: test !groups.is_empty() instead of re-entering the
  state.loaded() accessor for the same answer.
- nodedb_service.rs / app.rs / connection_manager.rs: replace external plan-ID
  comment narration (SEAM-02, CONN-01..07, "Phase 2") with comments that
  describe the code's actual behavior.

No logic, control flow, or signatures changed.

Author: farhan-syah

nodedb-studio/src/app.rs

@@ -32,9 +32,8 @@ pub fn App() -> Element {
     // real client can replace the mock without touching consumers.
     let service: Rc<dyn ConnectionService> = Rc::new(MockConnectionService);
 
-    // Prove the real-client stub is instantiable and object-safe behind the
-    // seam (SEAM-02). Not the active impl this phase — Phase 2 swaps it in —
-    // but constructing it here guarantees it compiles against the trait.
+    // Compile-time check: the real-client stub must be instantiable and
+    // object-safe behind the seam trait. Not the active impl yet — the mock is.
     let _real: Rc<dyn ConnectionService> = Rc::new(NodeDbConnectionService::default());
 
     use_context_provider(|| service.clone());

nodedb-studio/src/components/async_view.rs

@@ -45,13 +45,13 @@ pub struct AsyncViewProps {
     pub empty_message: String,
 }
 
-// Consumed by the notification popover (01-04) and later wired views.
+// Consumed by the notification popover and later wired views.
 #[component]
 pub fn AsyncView(props: AsyncViewProps) -> Element {
     if props.loading {
         return rsx! { div { class: "async-loading", "Loading…" } };
     }
-    if let Some(msg) = props.error.clone() {
+    if let Some(msg) = props.error {
         return rsx! {
             div { class: "async-error",
                 div { class: "async-error-msg", "{msg}" }

nodedb-studio/src/components/popovers/notification_popover.rs

@@ -120,7 +120,7 @@ pub fn NotificationPopover() -> Element {
                     on_retry: move |_| feed.restart(),
                 }
                 // Loaded -> the existing grouped list markup.
-                if state.loaded().is_some() {
+                if !groups.is_empty() {
                     for (group_name, items) in groups {
                         div { class: "notif-group-label", "{group_name}" }
                         for n in items {

nodedb-studio/src/services/nodedb_service.rs

@@ -1,9 +1,7 @@
-//! The real-client-backed seam impl. Phase 1: inert stub.
-//!
-//! Holds an `Option<NativeClient>` (None until Phase 2 connects). While the
-//! client is None, every method returns `StudioError::NotConnected` — never
-//! a panic or todo!(). Phase 2 (CONN-01..07) fills the client via
-//! ConnectionBuilder; that wiring is explicitly out of scope here.
+//! The real-client-backed `ConnectionService` impl. Currently an inert stub:
+//! every method returns `StudioError::NotConnected` until a real connection is
+//! opened. Holds an `Option<NativeClient>` so the type is forward-compatible
+//! with the future `ConnectionBuilder` wiring — no panic or `todo!()` in the interim.
 
 use async_trait::async_trait;
 use nodedb_client::NativeClient;
@@ -16,8 +14,8 @@ use crate::state::connections_registry::SavedConnection;
 
 #[derive(Default)]
 pub struct NodeDbConnectionService {
-    /// None until a real connection is opened in Phase 2 (ConnectionBuilder
-    /// fills this). The field exists now so the seam type is forward-compatible.
+    /// None until a real connection is opened. Field kept for forward-compatibility
+    /// with the future `ConnectionBuilder` wiring.
     #[allow(dead_code)]
     client: Option<NativeClient>,
 }

nodedb-studio/src/views/connection_manager.rs

@@ -57,7 +57,7 @@ pub fn ConnectionManager() -> Element {
                                         if let Ok(session) = service.connect(&name).await {
                                             active.set(Some(session));
                                         }
-                                        // Phase 2 / CONN-03 surfaces the Err case as an error state.
+                                        // Err case (e.g. offline): surfaced in a later wiring phase.
                                     });
                                 }
                             },