Skip to content

Commit 3f5feaa

Browse files
review: drop dead ViewPlaceholder, add list keys, neutral mock port
- delete unused ViewPlaceholder (Phase-3 stub, all views ported) - add key: to notification and database popover loops - test-nodedb mock port 5433 -> 2480 (avoid Postgres-port pattern-match) ignore
1 parent 41f14d0 commit 3f5feaa

5 files changed

Lines changed: 6 additions & 19 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,4 +106,5 @@ dmypy.json
106106
# Local reference only — not tracked
107107
docs/nodedb_lab_studio_mockup_v4.html
108108
specs/*
109+
docs/*
109110
.DS_Store

nodedb-studio/src/components/popovers/database_popover.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ pub fn DatabasePopover() -> Element {
4141
let item_class = if db == current { "db-popover-item current" } else { "db-popover-item" };
4242
rsx! {
4343
div {
44+
key: "{name}",
4445
class: "{item_class}",
4546
onclick: move |_| {
4647
if let Some(c) = active.write().as_mut() {

nodedb-studio/src/components/popovers/notification_popover.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ pub fn NotificationPopover() -> Element {
7979
let item_class = if n.unread { "notif-item" } else { "notif-item read" };
8080
rsx! {
8181
div {
82+
key: "{id}",
8283
class: "{item_class}",
8384
onclick: move |_| {
8485
for x in notifs.write().iter_mut() {

nodedb-studio/src/data/mock.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ pub fn connections() -> Vec<SavedConnection> {
122122
},
123123
SavedConnection {
124124
name: "test-nodedb".into(),
125-
meta: "nodedb · localhost:5433".into(),
125+
meta: "nodedb · localhost:2480".into(),
126126
sub: String::new(),
127127
status: ConnStatus::Offline,
128128
db_count: None,

nodedb-studio/src/views/mod.rs

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
pub mod connection_manager;
88
pub mod studio_shell;
99

10-
// Studio views (routed). Bodies are Phase-3 placeholders; Phase 4 ports the
11-
// faithful per-view content from the mockup.
10+
// Studio views (routed). One module per rail destination; each renders the
11+
// faithful per-view content ported from the mockup.
1212
pub mod admin;
1313
pub mod console;
1414
pub mod designer;
@@ -21,19 +21,3 @@ pub mod streams;
2121
pub mod sync;
2222
pub mod timeseries_dashboard;
2323
pub mod vector_space;
24-
25-
use dioxus::prelude::*;
26-
27-
/// Temporary placeholder body for views not yet ported. Replaced per view in
28-
/// Phase 4. Centralized so the stubs stay uniform and obviously provisional.
29-
#[component]
30-
pub fn ViewPlaceholder(title: String, note: String) -> Element {
31-
rsx! {
32-
div { class: "view active",
33-
div { class: "view-placeholder",
34-
h2 { "{title}" }
35-
p { "{note}" }
36-
}
37-
}
38-
}
39-
}

0 commit comments

Comments
 (0)